From: Joseph Myers <joseph@codesourcery.com>
To: "Gabriel F. T. Gomes" <gftg@linux.vnet.ibm.com>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH v4] Macroize inclusion of math-finite.h
Date: Wed, 29 Mar 2017 20:18:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1703292017570.25496@digraph.polyomino.org.uk> (raw)
In-Reply-To: <1490812858-32586-1-git-send-email-gftg@linux.vnet.ibm.com>
On Wed, 29 Mar 2017, Gabriel F. T. Gomes wrote:
> +/* Redirect __lgammal_r_finite to __lgamma_r_finite when __NO_LONG_DOUBLE_MATH
> + is set and to itself otherwise. It also redirects lgamma_r_finite and
> + lgammaf_r_finite to themselves. */
> +__MATH_REDIRCALL_INTERNAL (lgamma, _r, (_Mdouble_, int *));
The comment here should give the correct function names, __lgamma_r_finite
and __lgammaf_r_finite.
The patch is OK with that change.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2017-03-29 20:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 18:41 Gabriel F. T. Gomes
2017-03-29 20:18 ` Joseph Myers [this message]
2017-03-31 7:13 ` Andreas Schwab
2017-03-31 13:14 ` [PATCH] Fix condition for inclusion of math-finite.h for long double Gabriel F. T. Gomes
2017-03-31 14:52 ` [PATCH v2] " Gabriel F. T. Gomes
2017-03-31 15:57 ` Andreas Schwab
2017-03-31 19:30 ` Gabriel F. T. Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1703292017570.25496@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gftg@linux.vnet.ibm.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).