From: Joseph Myers <joseph@codesourcery.com>
To: Torvald Riegel <triegel@redhat.com>
Cc: Stefan Liebler <stli@linux.vnet.ibm.com>, <libc-alpha@sourceware.org>
Subject: Re: [PATCH 1/2] Optimize generic spinlock code and use C11 like atomic macros.
Date: Tue, 18 Apr 2017 21:17:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1704182112180.1253@digraph.polyomino.org.uk> (raw)
In-Reply-To: <1491487245.5374.161.camel@redhat.com>
On Thu, 6 Apr 2017, Torvald Riegel wrote:
> Have you been actually looking at these? The next line in the file is a
> pretty obvious hint that this is an LLSC machine, and atomic_exchange
> isn't defined anywhere:
>
> > /* Microblaze does not have byte and halfword forms of load and reserve and
> > diff --git a/sysdeps/mips/atomic-machine.h b/sysdeps/mips/atomic-machine.h
> > index 54c182b..3d9da0c 100644
> > --- a/sysdeps/mips/atomic-machine.h
> >
> > +++ b/sysdeps/mips/atomic-machine.h
> >
> > @@ -50,6 +50,8 @@ typedef uintmax_t uatomic_max_t;
> > #define __HAVE_64B_ATOMICS 1
> > #endif
> >
> > +#define ATOMIC_EXCHANGE_USES_CAS 0
> >
> > +
>
> Please ask the MIPS maintainers to review this.
MIPS is an LLSC machine. However, XLP has a direct atomic exchange
instruction (so that will be used if _MIPS_ARCH_XLP is defined, in the
case where this header is using compiler builtins).
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2017-04-18 21:17 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 16:32 Stefan Liebler
2016-12-16 16:32 ` [PATCH 2/2] S390: Use generic spinlock code Stefan Liebler
2017-02-08 14:49 ` Stefan Liebler
2017-02-13 20:39 ` Torvald Riegel
2017-02-15 16:26 ` Stefan Liebler
2017-02-18 17:05 ` Torvald Riegel
2017-03-14 15:55 ` Stefan Liebler
2017-03-21 15:43 ` Stefan Liebler
2017-04-06 12:27 ` Torvald Riegel
2016-12-19 12:14 ` [PATCH 1/2] Optimize generic spinlock code and use C11 like atomic macros Szabolcs Nagy
2017-02-08 14:49 ` Stefan Liebler
2017-02-13 20:29 ` Torvald Riegel
2017-02-15 9:36 ` Stefan Liebler
2017-02-18 16:57 ` Torvald Riegel
2017-02-19 9:20 ` Florian Weimer
2017-02-20 13:11 ` Torvald Riegel
2017-02-26 7:55 ` Florian Weimer
2017-02-26 20:06 ` Torvald Riegel
2017-02-26 20:29 ` Florian Weimer
2017-02-26 20:35 ` Torvald Riegel
2017-02-27 17:57 ` Szabolcs Nagy
2017-02-28 7:15 ` Torvald Riegel
2017-03-14 15:55 ` Stefan Liebler
2017-02-20 12:15 ` Stefan Liebler
2017-02-20 13:51 ` Torvald Riegel
2017-03-14 15:55 ` Stefan Liebler
2017-03-21 15:43 ` Stefan Liebler
2017-03-22 12:56 ` Szabolcs Nagy
2017-03-23 16:16 ` Stefan Liebler
2017-03-23 17:52 ` Szabolcs Nagy
2017-04-06 12:04 ` Torvald Riegel
2017-03-27 13:08 ` Stefan Liebler
2017-04-04 10:29 ` [PING] " Stefan Liebler
2017-03-29 14:16 ` Stefan Liebler
2017-04-06 14:00 ` Torvald Riegel
2017-04-07 16:23 ` Stefan Liebler
2017-04-09 13:51 ` Torvald Riegel
2017-04-10 12:00 ` Stefan Liebler
2017-04-18 13:09 ` Stefan Liebler
2017-04-25 6:47 ` Stefan Liebler
2017-05-03 11:38 ` [PATCH 1/2] [PING] " Stefan Liebler
2017-05-10 13:00 ` Stefan Liebler
2017-05-17 13:09 ` Stefan Liebler
2017-05-24 6:37 ` Stefan Liebler
2017-05-30 7:18 ` Torvald Riegel
2017-05-31 8:29 ` Stefan Liebler
2017-05-31 16:48 ` Torvald Riegel
2017-06-01 13:40 ` Joseph Myers
2017-06-01 14:33 ` Torvald Riegel
2017-06-06 7:51 ` [PATCH 1/2] [COMMITTED] " Stefan Liebler
2017-04-10 8:17 ` [PATCH 1/2] " Andreas Schwab
2017-04-10 12:00 ` Stefan Liebler
2017-04-10 13:36 ` Andreas Schwab
2017-04-11 7:06 ` Stefan Liebler
2017-04-11 8:45 ` Andreas Schwab
2017-04-11 10:15 ` Stefan Liebler
2017-04-11 12:05 ` Andreas Schwab
2017-04-11 12:19 ` Stefan Liebler
2017-04-11 13:08 ` Zack Weinberg
2017-04-13 16:36 ` Torvald Riegel
2017-05-30 21:00 ` Tulio Magno Quites Machado Filho
2017-04-18 21:17 ` Joseph Myers [this message]
2017-04-19 8:27 ` Stefan Liebler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1704182112180.1253@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=stli@linux.vnet.ibm.com \
--cc=triegel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).