From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12251 invoked by alias); 9 May 2017 21:28:30 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 11696 invoked by uid 89); 9 May 2017 21:28:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Date: Tue, 09 May 2017 21:28:00 -0000 From: Joseph Myers To: Zack Weinberg CC: , , , , , Subject: Re: [PATCH 02/10] Suppress internal declarations for most of the testsuite. In-Reply-To: <20170509154103.11973-3-zackw@panix.com> Message-ID: References: <20170509154103.11973-1-zackw@panix.com> <20170509154103.11973-3-zackw@panix.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2017-05/txt/msg00210.txt.bz2 On Tue, 9 May 2017, Zack Weinberg wrote: > diff --git a/stdlib/tst-strtod1i.c b/stdlib/tst-strtod1i.c > new file mode 100644 > index 0000000000..d8a952f606 > --- /dev/null > +++ b/stdlib/tst-strtod1i.c > @@ -0,0 +1,83 @@ > +/* Copyright (C) 1991-2017 Free Software Foundation, Inc. Should have descriptive comment before the copyright notice. > diff --git a/stdlib/tst-strtod5.c b/stdlib/tst-strtod5.c > index 337c746989..d53b17c51a 100644 > --- a/stdlib/tst-strtod5.c > +++ b/stdlib/tst-strtod5.c > @@ -1,3 +1,20 @@ > +/* Copyright (C) 2007-2017 Free Software Foundation, Inc. Likewise. > diff --git a/stdlib/tst-strtod5i.c b/stdlib/tst-strtod5i.c > new file mode 100644 > index 0000000000..e9489c1747 > --- /dev/null > +++ b/stdlib/tst-strtod5i.c > @@ -0,0 +1,99 @@ > +/* Copyright (C) 2007-2017 Free Software Foundation, Inc. Likewise. The patch is OK with those changes, provided you've verified unchanged installed stripped shared libraries on at least one platform (unless there's some reason for the libraries to change), and an unchanged set of tests run on at least one platform (except for any deliberate changes such as from splitting strtod tests). -- Joseph S. Myers joseph@codesourcery.com