From: Joseph Myers <joseph@codesourcery.com>
To: Zack Weinberg <zackw@panix.com>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH 2/6] Committed: Remove __need macros from signal.h.
Date: Mon, 22 May 2017 11:25:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1705221120580.21862@digraph.polyomino.org.uk> (raw)
In-Reply-To: <alpine.DEB.2.20.1705221117410.21862@digraph.polyomino.org.uk>
The basic issue behind this build breakage is: bits/siginfo-arch.h uses
#undef/#define to make adjustments to defaults from more than one other
bits/ header (so it's included from bits/types/siginfo_t.h to adjust some
defines from there, but also from bits/siginfo-consts.h to adjust some
defines from there). For this to work, however, it can only safely be
included after both sets of defaults have been defined. I think either it
needs to be split up into two headers, each one only included after the
relevant defaults have been defined, or the defaults all need to come in
one place. (One possibility for the split would be a header that defines
only __SI_ASYNCIO_AFTER_SIGIO, at which point you don't need a #undef,
just a version that defines it to 1 and a version that defines it to 0.)
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2017-05-22 11:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-20 23:18 [PATCH 0/6] Elimination of __need macros, round 3(?) Zack Weinberg
2017-05-20 23:18 ` [PATCH 2/6] Committed: Remove __need macros from signal.h Zack Weinberg
2017-05-21 7:19 ` Andreas Schwab
2017-05-21 13:55 ` Zack Weinberg
2017-05-22 11:18 ` Joseph Myers
2017-05-22 11:25 ` Joseph Myers [this message]
2017-05-22 11:59 ` Zack Weinberg
2017-05-23 2:33 ` Zack Weinberg
2017-05-20 23:18 ` [PATCH 1/6] Committed: Remove __need_list_t and __need_res_state Zack Weinberg
2017-05-20 23:18 ` [PATCH 6/6] Remove __need_schedparam and __cpu_set_t_defined Zack Weinberg
2017-05-20 23:18 ` [PATCH 3/6] Remove __need macros from errno.h (__need_Emath, __need_error_t) Zack Weinberg
2017-05-20 23:18 ` [PATCH 5/6] Remove __need_IOV_MAX and __need_FOPEN_MAX Zack Weinberg
2017-05-20 23:18 ` [PATCH 4/6] Remove __need macros from stdio.h and wchar.h Zack Weinberg
2017-05-23 17:42 ` [PATCH 0/6] Elimination of __need macros, round 3(?) Chris Metcalf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1705221120580.21862@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=zackw@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).