From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118069 invoked by alias); 22 May 2017 11:25:55 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 118047 invoked by uid 89); 22 May 2017 11:25:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Date: Mon, 22 May 2017 11:25:00 -0000 From: Joseph Myers To: Zack Weinberg CC: Subject: Re: [PATCH 2/6] Committed: Remove __need macros from signal.h. In-Reply-To: Message-ID: References: <20170520231823.20924-1-zackw@panix.com> <20170520231823.20924-3-zackw@panix.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) To svr-ies-mbx-02.mgc.mentorg.com (139.181.222.2) X-SW-Source: 2017-05/txt/msg00646.txt.bz2 The basic issue behind this build breakage is: bits/siginfo-arch.h uses #undef/#define to make adjustments to defaults from more than one other bits/ header (so it's included from bits/types/siginfo_t.h to adjust some defines from there, but also from bits/siginfo-consts.h to adjust some defines from there). For this to work, however, it can only safely be included after both sets of defaults have been defined. I think either it needs to be split up into two headers, each one only included after the relevant defaults have been defined, or the defaults all need to come in one place. (One possibility for the split would be a header that defines only __SI_ASYNCIO_AFTER_SIGIO, at which point you don't need a #undef, just a version that defines it to 1 and a version that defines it to 0.) -- Joseph S. Myers joseph@codesourcery.com