* Update nios2, sparc32 localplt.data files for recent GCC change [committed]
@ 2017-06-09 16:26 Joseph Myers
2017-06-09 17:04 ` Andreas Schwab
0 siblings, 1 reply; 3+ messages in thread
From: Joseph Myers @ 2017-06-09 16:26 UTC (permalink / raw)
To: libc-alpha
A recent GCC change to expand floating-point classification built-in
functions inline using integer rather than floating-point arithmetic
in some cases resulted in localplt test failures for nios2 and sparc32
<https://sourceware.org/ml/libc-testresults/2017-q2/msg00320.html>.
This patch updates the localplt.data files in question to mark the
relevant symbols as optional / add a new optional symbol. (The GCC
patch has been reverted because of other problems it caused, but one
can assume it will be applied again, without changes that would affect
the PLT entries generated, once those issues have been resolved.)
Tested with build-many-glibcs.py. Committed.
2017-06-09 Joseph Myers <joseph@codesourcery.com>
* sysdeps/unix/sysv/linux/nios2/localplt.data (__gtdf2): Mark
libc.so PLT entry optional.
(__gtsf2): Likewise.
(__unorddf2): Likewise.
(__unordsf2): Likewise.
* sysdeps/unix/sysv/linux/sparc/sparc32/localplt.data (_Q_fgt):
New optional libc.so PLT entry.
diff --git a/sysdeps/unix/sysv/linux/nios2/localplt.data b/sysdeps/unix/sysv/linux/nios2/localplt.data
index 584963d..b0d6dca 100644
--- a/sysdeps/unix/sysv/linux/nios2/localplt.data
+++ b/sysdeps/unix/sysv/linux/nios2/localplt.data
@@ -1,10 +1,10 @@
libc.so: realloc
libc.so: __floatsisf
-libc.so: __gtdf2
+libc.so: __gtdf2 ?
libc.so: __ltdf2
libc.so: __gedf2
libc.so: malloc
-libc.so: __gtsf2
+libc.so: __gtsf2 ?
libc.so: __nesf2
libc.so: memalign
libc.so: __mulsf3
@@ -12,10 +12,10 @@ libc.so: __floatunsisf
libc.so: __addsf3
libc.so: __fixsfsi
libc.so: __subsf3
-libc.so: __unorddf2
+libc.so: __unorddf2 ?
libc.so: calloc
libc.so: __muldf3
-libc.so: __unordsf2
+libc.so: __unordsf2 ?
libc.so: free
libc.so: __subdf3
libc.so: __ledf2
diff --git a/sysdeps/unix/sysv/linux/sparc/sparc32/localplt.data b/sysdeps/unix/sysv/linux/sparc/sparc32/localplt.data
index c9786fd..2f6ff3c 100644
--- a/sysdeps/unix/sysv/linux/sparc/sparc32/localplt.data
+++ b/sysdeps/unix/sysv/linux/sparc/sparc32/localplt.data
@@ -3,6 +3,7 @@ libc.so: _Q_cmp ?
libc.so: _Q_div ?
libc.so: _Q_feq ?
libc.so: _Q_fge ?
+libc.so: _Q_fgt ?
libc.so: _Q_fle ?
libc.so: _Q_flt ?
libc.so: _Q_fne ?
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Update nios2, sparc32 localplt.data files for recent GCC change [committed]
2017-06-09 16:26 Update nios2, sparc32 localplt.data files for recent GCC change [committed] Joseph Myers
@ 2017-06-09 17:04 ` Andreas Schwab
2017-06-09 20:12 ` Joseph Myers
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Schwab @ 2017-06-09 17:04 UTC (permalink / raw)
To: Joseph Myers; +Cc: libc-alpha
On Jun 09 2017, Joseph Myers <joseph@codesourcery.com> wrote:
> A recent GCC change to expand floating-point classification built-in
> functions inline using integer rather than floating-point arithmetic
> in some cases resulted in localplt test failures for nios2 and sparc32
> <https://sourceware.org/ml/libc-testresults/2017-q2/msg00320.html>.
> This patch updates the localplt.data files in question to mark the
> relevant symbols as optional / add a new optional symbol.
Perhaps all libgcc references should be marked optional?
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Update nios2, sparc32 localplt.data files for recent GCC change [committed]
2017-06-09 17:04 ` Andreas Schwab
@ 2017-06-09 20:12 ` Joseph Myers
0 siblings, 0 replies; 3+ messages in thread
From: Joseph Myers @ 2017-06-09 20:12 UTC (permalink / raw)
To: Andreas Schwab; +Cc: libc-alpha
On Fri, 9 Jun 2017, Andreas Schwab wrote:
> On Jun 09 2017, Joseph Myers <joseph@codesourcery.com> wrote:
>
> > A recent GCC change to expand floating-point classification built-in
> > functions inline using integer rather than floating-point arithmetic
> > in some cases resulted in localplt test failures for nios2 and sparc32
> > <https://sourceware.org/ml/libc-testresults/2017-q2/msg00320.html>.
> > This patch updates the localplt.data files in question to mark the
> > relevant symbols as optional / add a new optional symbol.
>
> Perhaps all libgcc references should be marked optional?
Seems reasonable (the issue is actually floating-point functions that are
defined in and exported from libc rather than libgcc on certain
platforms).
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-09 20:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-09 16:26 Update nios2, sparc32 localplt.data files for recent GCC change [committed] Joseph Myers
2017-06-09 17:04 ` Andreas Schwab
2017-06-09 20:12 ` Joseph Myers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).