public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Add powf bench tests
@ 2017-06-09 21:53 Paul Clarke
  2017-06-09 22:30 ` Joseph Myers
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Clarke @ 2017-06-09 21:53 UTC (permalink / raw)
  To: libc-alpha; +Cc: Joseph Myers

2017-06-09  Paul A. Clarke  <pc@us.ibm.com>

	* benchtests/Makefile (bench-math): Add powf.
	* benchtests/powf-inputs: Copy from benchtests/pow-inputs.
---
 benchtests/Makefile                    | 2 +-
 benchtests/{pow-inputs => powf-inputs} | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
 copy benchtests/{pow-inputs => powf-inputs} (99%)

diff --git a/benchtests/Makefile b/benchtests/Makefile
index 7f5fda5..f49e9a0 100644
--- a/benchtests/Makefile
+++ b/benchtests/Makefile
@@ -23,7 +23,7 @@ subdir := benchtests
 include ../Makeconfig
 bench-math := acos acosh asin asinh atan atanh cos cosh exp exp2 log log2 \
 	      modf pow rint sin sincos sinh sqrt tan tanh fmin fmax fminf \
-	      fmaxf
+	      fmaxf powf
 
 bench-pthread := pthread_once
 
diff --git a/benchtests/pow-inputs b/benchtests/powf-inputs
similarity index 99%
copy from benchtests/pow-inputs
copy to benchtests/powf-inputs
index 78f8ac7..cb8620d 100644
--- a/benchtests/pow-inputs
+++ b/benchtests/powf-inputs
@@ -1,5 +1,5 @@
-## args: double:double
-## ret: double
+## args: float:float
+## ret: float
 ## includes: math.h
 42.0, 42.0
 -0x1.086f771a2b37bp696, 0x1.592b453fe869fp-81
-- 
1.8.3.1

Regards,
PC

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Add powf bench tests
  2017-06-09 21:53 [PATCH] Add powf bench tests Paul Clarke
@ 2017-06-09 22:30 ` Joseph Myers
  0 siblings, 0 replies; 2+ messages in thread
From: Joseph Myers @ 2017-06-09 22:30 UTC (permalink / raw)
  To: Paul Clarke; +Cc: libc-alpha

On Fri, 9 Jun 2017, Paul Clarke wrote:

> diff --git a/benchtests/pow-inputs b/benchtests/powf-inputs
> similarity index 99%
> copy from benchtests/pow-inputs
> copy to benchtests/powf-inputs

A large proportion of the pow inputs are sufficiently large or small that 
they would round to 0 or infinity as float values, or the result would 
round to 0, infinity or 1 as a float value.  I don't think such special 
cases should be considered typical and so I don't think copying the pow 
inputs is a good way of producing a set of benchmark inputs to powf.

-- 
Joseph S. Myers
joseph@codesourcery.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-06-09 22:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-09 21:53 [PATCH] Add powf bench tests Paul Clarke
2017-06-09 22:30 ` Joseph Myers

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).