public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* Fix XPG4 bsd_signal namespace (bug 21552)
@ 2017-06-05 21:19 Joseph Myers
  2017-06-12 15:37 ` Ping " Joseph Myers
  2017-06-12 16:43 ` Andreas Schwab
  0 siblings, 2 replies; 3+ messages in thread
From: Joseph Myers @ 2017-06-05 21:19 UTC (permalink / raw)
  To: libc-alpha

bsd_signal was added in XPG4.2, so should be declared for
__USE_XOPEN_EXTENDED, instead of the present __USE_XOPEN condition.
This patch fixes the condition accordingly.

Tested for x86_64.  Because of other namespace problems this does not
allow any conform/ XFAILs to be removed.

2017-06-05  Joseph Myers  <joseph@codesourcery.com>

	[BZ #21552]
	* signal/signal.h (bsd_signal): Declare if [__USE_XOPEN_EXTENDED],
	not [__USE_XOPEN].

diff --git a/signal/signal.h b/signal/signal.h
index b311473..8a140d4 100644
--- a/signal/signal.h
+++ b/signal/signal.h
@@ -94,7 +94,7 @@ extern __sighandler_t __REDIRECT_NTH (signal,
 # endif
 #endif
 
-#if defined __USE_XOPEN && !defined __USE_XOPEN2K8
+#if defined __USE_XOPEN_EXTENDED && !defined __USE_XOPEN2K8
 /* The X/Open definition of `signal' conflicts with the BSD version.
    So they defined another function `bsd_signal'.  */
 extern __sighandler_t bsd_signal (int __sig, __sighandler_t __handler)

-- 
Joseph S. Myers
joseph@codesourcery.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Ping Re: Fix XPG4 bsd_signal namespace (bug 21552)
  2017-06-05 21:19 Fix XPG4 bsd_signal namespace (bug 21552) Joseph Myers
@ 2017-06-12 15:37 ` Joseph Myers
  2017-06-12 16:43 ` Andreas Schwab
  1 sibling, 0 replies; 3+ messages in thread
From: Joseph Myers @ 2017-06-12 15:37 UTC (permalink / raw)
  To: libc-alpha

Ping.  This patch 
<https://sourceware.org/ml/libc-alpha/2017-06/msg00191.html> is pending 
review.

-- 
Joseph S. Myers
joseph@codesourcery.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Fix XPG4 bsd_signal namespace (bug 21552)
  2017-06-05 21:19 Fix XPG4 bsd_signal namespace (bug 21552) Joseph Myers
  2017-06-12 15:37 ` Ping " Joseph Myers
@ 2017-06-12 16:43 ` Andreas Schwab
  1 sibling, 0 replies; 3+ messages in thread
From: Andreas Schwab @ 2017-06-12 16:43 UTC (permalink / raw)
  To: Joseph Myers; +Cc: libc-alpha

On Jun 05 2017, Joseph Myers <joseph@codesourcery.com> wrote:

> 	[BZ #21552]
> 	* signal/signal.h (bsd_signal): Declare if [__USE_XOPEN_EXTENDED],
> 	not [__USE_XOPEN].

Ok.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-06-12 16:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-05 21:19 Fix XPG4 bsd_signal namespace (bug 21552) Joseph Myers
2017-06-12 15:37 ` Ping " Joseph Myers
2017-06-12 16:43 ` Andreas Schwab

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).