From: Joseph Myers <joseph@codesourcery.com>
To: Akhilesh Kumar <akhilesh.k@samsung.com>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH 1/1] Made regs from comma-separated to dashed range
Date: Tue, 22 Aug 2017 15:14:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1708221509100.23998@digraph.polyomino.org.uk> (raw)
In-Reply-To: <1503409149-20399-1-git-send-email-akhilesh.k@samsung.com>
On Tue, 22 Aug 2017, Akhilesh Kumar wrote:
> The <regs> can be a comma-separated list, or a dashed range, or a
> mixture.
The fact that there are two different ways of writing some code is not a
justification for changing from one to the other. You need to explain
why your change is an improvement. For example, is there some external
coding standard for ARM assembly code that you wish to propose glibc
follows, which recommends one alternative over the other in this case?
And, given that there are many uses of both syntaxes in glibc, not just in
those two files, are you proposing to change all such uses to the
preferred syntax if we reach consensus on the preferred syntax?
In such a case, where it's necessary first to reach consensus on the
preferred option before making things consistent, and there is no
user-visible bug, I don't think filing bugs in Bugzilla is appropriate.
Rather, you should start with an analysis of the issue and a recommended
approach, seeking a discussion leading to consensus.
You also need to describe how a patch was tested (e.g. by verifying that
binaries of glibc built before and after the patch were identical). And
note the standard syntax for ChangeLog entries, as used in existing
examples.
--
Joseph S. Myers
joseph@codesourcery.com
prev parent reply other threads:[~2017-08-22 15:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170822134423epcas5p267a8d869468390a7262a7c83344b9b3c@epcas5p2.samsung.com>
2017-08-22 13:44 ` Akhilesh Kumar
2017-08-22 15:14 ` Joseph Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1708221509100.23998@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=akhilesh.k@samsung.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).