From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108187 invoked by alias); 28 Aug 2017 20:48:17 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 108026 invoked by uid 89); 28 Aug 2017 20:48:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=Hx-languages-length:891, documents X-HELO: relay1.mentorg.com Date: Mon, 28 Aug 2017 20:48:00 -0000 From: Joseph Myers To: Steve Ellcey CC: DJ Delorie , Subject: Re: [PATCH] Remove compat from DEFAULT_CONFIG lookup strings In-Reply-To: <1503951778.28672.139.camel@cavium.com> Message-ID: References: <1503951778.28672.139.camel@cavium.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2017-08/txt/msg01215.txt.bz2 On Mon, 28 Aug 2017, Steve Ellcey wrote: > On Tue, 2017-08-22 at 17:07 -0400, DJ Delorie wrote: > > I find the slight inconsistency in the use of [NOTFOUND=return] in > > initgroups.c disconcerting, but IMHO that's irrelevent for this > > particular change. > > > > LGTM. > > Joseph, do you have any issues with the latest version of this patch? > I don't want to go ahead unless you think this has addressed the issues > you had with the initial patch. I think the documentation in the manual needs to be updated. Specifically, nss.texi documents the defaults for various NSS databases, and it needs to be made to reflect how the defaults depend on how glibc is configured. Does the "nis [NOTFOUND=return] files" default in nsswitch.c:__nss_database_lookup need to change as well? -- Joseph S. Myers joseph@codesourcery.com