From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31487 invoked by alias); 7 Sep 2017 14:45:36 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 31459 invoked by uid 89); 7 Sep 2017 14:45:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=Hx-languages-length:1217 X-HELO: relay1.mentorg.com Date: Thu, 07 Sep 2017 14:45:00 -0000 From: Joseph Myers To: "Gabriel F. T. Gomes" CC: Subject: Re: [PATCH 3/3] powerpc64le: Disable compiler support for float128 when reusing ldbl-128 In-Reply-To: <20170907104352.7748-4-gabriel@inconstante.eti.br> Message-ID: References: <20170907104352.7748-1-gabriel@inconstante.eti.br> <20170907104352.7748-4-gabriel@inconstante.eti.br> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2017-09/txt/msg00297.txt.bz2 On Thu, 7 Sep 2017, Gabriel F. T. Gomes wrote: > Some files under sysdeps/ieee754/ldbl-128ibm are able to reuse the > implementation in sysdeps/ieee754/ldbl-128 by defining _Float128 to long > double. This relies on compiler support for _Float128 being disabled. > > On powerpc, such support is currently disabled by default, however, it > will get enabled by default [1], requiring that this Makefile actively > disable compiler support for float128 for the required files. I think it would be better to stop #include of ldbl-128 files from ldbl-128ibm. That is, copy the relevant source files (in the case of e_expl.c that's actually t_expl.h) to ldbl-128ibm, with _Float128 converted to long double and L() also expanded back to adding L suffixes. And, in the e_lgammal_r.c case, then eliminate the present LDBL_MANT_DIG conditionals from both copies. Long term I'd like the ldbl-128 files to e.g. use f128 constant suffixes directly (once we can assume GCC >= 7 to build glibc), with such changes cleaning up the code but being incompatible with its use also for ldbl-128ibm. -- Joseph S. Myers joseph@codesourcery.com