From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104906 invoked by alias); 7 Sep 2017 23:21:32 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 104716 invoked by uid 89); 7 Sep 2017 23:21:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=HTo:D*fr, Hx-languages-length:1473 X-HELO: relay1.mentorg.com Date: Thu, 07 Sep 2017 23:21:00 -0000 From: Joseph Myers To: "Albert ARIBAUD (3ADEV)" CC: Subject: Re: [RFC PATCH 00/52] Make GLIBC Y2038-proof In-Reply-To: <20170907224219.12483-1-albert.aribaud@3adev.fr> Message-ID: References: <20170907224219.12483-1-albert.aribaud@3adev.fr> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2017-09/txt/msg00366.txt.bz2 General observations on this patch series: * Nothing should use a GLIBC_Y2038 version. Use GLIBC_2.27 and update as necessary during rebases if this doesn't get into 2.27. * Nothing should go in architecture-specific files such as sysdeps/unix/sysv/linux/arm/Versions. For OS-independent interfaces use files such as time/Versions - wherever the existing versions of those interfaces for existing time_t are. * How such a patch series was tested needs to be described in the summary of the series. For a series like this, full testsuite runs on multiple 32-bit and 64-bit architectures as well as use of build-many-glibcs.py to do the compilation tests for (almost) all configurations is important (or if a series is a preliminary version with limited architecture support, that should be stated explicitly, but the full testsuite should still pass on at least one 32-bit and one 64-bit architecture). * I'd expect lots of extra tests using _TIME_BITS=64 to be added in such a patch series, to make sure that every new ABI is covered by the testsuite. * Documentation of _TIME_BITS is clearly needed. * You need to make sure that new ABIs are not added / used on platforms where time_t is already 64-bit. * All new files need a descriptive first line before the copyright notice. * All copyright ranges in new files should end with 2017. * No "Contributed by" in new files. -- Joseph S. Myers joseph@codesourcery.com