From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129364 invoked by alias); 8 Sep 2017 16:24:44 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 129325 invoked by uid 89); 8 Sep 2017 16:24:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Date: Fri, 08 Sep 2017 16:24:00 -0000 From: Joseph Myers To: "Gabriel F. T. Gomes" CC: Subject: Re: [PATCH 2/3] powerpc: Add redirection for finitef128, isinf128, and isnanf128 In-Reply-To: <20170908122540.4ee0fffb@keller> Message-ID: References: <20170907104352.7748-1-gabriel@inconstante.eti.br> <20170907104352.7748-3-gabriel@inconstante.eti.br> <20170908122540.4ee0fffb@keller> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2017-09/txt/msg00385.txt.bz2 On Fri, 8 Sep 2017, Gabriel F. T. Gomes wrote: > On top of that, math/math.h includes bits/mathcalls-helper-functions.h > (once for each floating-point type). However, the declarations in > bits/mathcalls-helper-functions.h are macroized using __MATHDECL_1. > __MATHDECL_1 receives the suffix (f, l, f128, or nothing) as a parameter > and expands the base name (e.g.: __finite). > > When s_finite.c defines __finite as __redirect_finite, all declarations in > bits/mathcalls-helper-functions.h are also redefined. That doesn't happen > with s_finitef.c because it only defines __finitef, which does not match > with anything in bits/mathcalls-helper-functions.h. I think that this key point - that the function name gets macro expanded before the concatenation - needs explaining in comments in all three affected source files to justify why they are defining the macros for other types. -- Joseph S. Myers joseph@codesourcery.com