From: Joseph Myers <joseph@codesourcery.com>
To: "Gabriel F. T. Gomes" <gabriel@inconstante.eti.br>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH v2 3/5] ldbl-128ibm: Copy implementations from ldbl-128 instead of including them
Date: Mon, 11 Sep 2017 14:41:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1709111438070.18599@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20170911011654.28743-4-gabriel@inconstante.eti.br>
On Sun, 10 Sep 2017, Gabriel F. T. Gomes wrote:
> diff --git a/sysdeps/ieee754/ldbl-128ibm/e_expl.c b/sysdeps/ieee754/ldbl-128ibm/e_expl.c
> index 10df6bb7d5..3d32f8f0b0 100644
> --- a/sysdeps/ieee754/ldbl-128ibm/e_expl.c
> +++ b/sysdeps/ieee754/ldbl-128ibm/e_expl.c
> @@ -69,7 +69,7 @@
> #define _Float128 long double
> #define L(x) x ## L
>
> -#include <sysdeps/ieee754/ldbl-128/t_expl.h>
> +#include <sysdeps/ieee754/ldbl-128ibm/t_expl.h>
Should just be #include "t_expl.h".
> diff --git a/sysdeps/ieee754/ldbl-128ibm/e_j0l.c b/sysdeps/ieee754/ldbl-128ibm/e_j0l.c
> index 00bce29284..ec71904720 100644
> --- a/sysdeps/ieee754/ldbl-128ibm/e_j0l.c
> +++ b/sysdeps/ieee754/ldbl-128ibm/e_j0l.c
> @@ -1,5 +1,867 @@
> -/* Looks like we can use ieee854 e_j0l.c as is for IBM extended format. */
> +/* Bessel function of order zero. IBM Extended Precision version.
> + Copyright (C) 2017 Free Software Foundation, Inc.
> + This file is part of the GNU C Library.
> +
> + The GNU C Library is free software; you can redistribute it and/or
> + modify it under the terms of the GNU Lesser General Public
> + License as published by the Free Software Foundation; either
> + version 2.1 of the License, or (at your option) any later version.
> +
> + The GNU C Library is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + Lesser General Public License for more details.
> +
> + You should have received a copy of the GNU Lesser General Public
> + License along with the GNU C Library; if not, see
> + <http://www.gnu.org/licenses/>. */
> +
> +/* This file was copied from sysdeps/ieee754/ldbl-128/e_j0l.c. */
When copying you need to preserve the original copyright / license notice.
Note that this is copyright Stephen L. Moshier, not FSF.
> diff --git a/sysdeps/ieee754/ldbl-128ibm/e_j1l.c b/sysdeps/ieee754/ldbl-128ibm/e_j1l.c
Likewise.
> diff --git a/sysdeps/ieee754/ldbl-128ibm/e_lgammal_r.c b/sysdeps/ieee754/ldbl-128ibm/e_lgammal_r.c
Likewise.
> diff --git a/sysdeps/ieee754/ldbl-128ibm/s_cbrtl.c b/sysdeps/ieee754/ldbl-128ibm/s_cbrtl.c
Likewise.
> diff --git a/sysdeps/ieee754/ldbl-128ibm/t_expl.h b/sysdeps/ieee754/ldbl-128ibm/t_expl.h
Likewise (this one is FSF-copyright, but should still have the dates
1999-2017 - but not the "Contributed by").
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2017-09-11 14:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 1:17 [PATCH v2 0/5] Fixes for gcc enabling -mfloat128 by default Gabriel F. T. Gomes
2017-09-11 1:17 ` [PATCH v2 1/5] powerpc64le: Add -mfloat128 to tst-strtod-nan-locale testcase Gabriel F. T. Gomes
2017-09-11 1:17 ` [PATCH v2 2/5] powerpc: Add redirection for finitef128, isinf128, and isnanf128 Gabriel F. T. Gomes
2017-09-11 1:17 ` [PATCH v2 3/5] ldbl-128ibm: Copy implementations from ldbl-128 instead of including them Gabriel F. T. Gomes
2017-09-11 14:41 ` Joseph Myers [this message]
2017-09-11 1:17 ` [PATCH v2 5/5] Remove conditional on LDBL_MANT_DIG from e_lgammal_r.c Gabriel F. T. Gomes
2017-09-11 1:18 ` [PATCH v2 4/5] ldbl-128ibm: Automatic replacing of _Float128 and L() Gabriel F. T. Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1709111438070.18599@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gabriel@inconstante.eti.br \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).