From: Joseph Myers <joseph@codesourcery.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH v2] Use execveat syscall in fexecve
Date: Mon, 11 Sep 2017 20:38:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1709112035390.29946@digraph.polyomino.org.uk> (raw)
In-Reply-To: <2a21b0d6-5f62-a711-2b4a-616ebb798963@linaro.org>
On Mon, 11 Sep 2017, Adhemerval Zanella wrote:
> > +# ifndef __ASSUME_EXECVEAT
> > + if (errno != ENOSYS)
> > + return -1;
> > +# endif
> > +#endif
>
> Do we really need to add another __ASSUME_* that eventually we will need to
> cleanup? Can't we just check fo __NR_execvat, call it and if it fails with
> ENOSYS use the current code as fallback? The drawback would be that the
> fallback code would be mainly dead code for newer kernels.
We have the ENOSYS code there and the subsequent fallback that will
eventually need cleaning up *anyway*. Having the __ASSUME_* macro makes
it obvious in future exactly what changes should be made for the cleanup
and exactly when it is possible to do that cleanup. I think having such
macros for any case with fallback code that can be cleaned up in future is
a good idea for that reason.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2017-09-11 20:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 9:06 [PATCH] " Andreas Schwab
2017-09-07 11:27 ` Florian Weimer
2017-09-11 10:23 ` [PATCH v2] " Andreas Schwab
2017-09-11 20:30 ` Adhemerval Zanella
2017-09-11 20:38 ` Joseph Myers [this message]
2017-09-11 20:59 ` Florian Weimer
2017-09-11 22:58 ` Adhemerval Zanella
2017-09-14 8:05 ` Andreas Schwab
2017-09-14 13:44 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1709112035390.29946@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).