From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107533 invoked by alias); 31 Oct 2017 18:16:50 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 107522 invoked by uid 89); 31 Oct 2017 18:16:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=Hx-languages-length:865, configurations X-HELO: relay1.mentorg.com Date: Tue, 31 Oct 2017 18:16:00 -0000 From: Joseph Myers To: Adhemerval Zanella CC: Subject: Re: [PATCH 01/25] arm: Implement memcpy ifunc selection in C In-Reply-To: <1509044813-9951-2-git-send-email-adhemerval.zanella@linaro.org> Message-ID: References: <1509044813-9951-1-git-send-email-adhemerval.zanella@linaro.org> <1509044813-9951-2-git-send-email-adhemerval.zanella@linaro.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) X-SW-Source: 2017-10/txt/msg01424.txt.bz2 On Thu, 26 Oct 2017, Adhemerval Zanella wrote: > This patch refactor ARM memcpy ifunc selector to a C implementation. > No functional change is expected, including ifunc resolution rules. > > It also adds some cleanup: > > - Internal memcpy hidden definition (__GI_memcpy) is now a hidden > symbol. > > - No need to create hidden definition for the ifunc variants. > > Checked on armv7-linux-gnueabihf and with a build for arm-linux-gnueabi, > arm-linux-gnueabihf with and without multiarch support and with both > GCC 7.1 and GCC mainline. I also checked with the some possible > multiarch different configurations that trigger different memcpy > buids (__ARM_NEON__ && !__SOFT_FP__, !__ARM_NEON__ && !__SOFT_FP__, and > !__ARM_NEON__ && __SOFT_FP__). OK. -- Joseph S. Myers joseph@codesourcery.com