From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19140 invoked by alias); 20 Dec 2017 16:38:56 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 19103 invoked by uid 89); 20 Dec 2017 16:38:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Date: Wed, 20 Dec 2017 16:38:00 -0000 From: Joseph Myers To: Palmer Dabbelt CC: , Andrew Waterman , Darius Rad , Subject: Re: [PATCH v2 03/15] RISC-V: Startup and Dynamic Loading Code In-Reply-To: <20171220072022.26909-4-palmer@dabbelt.com> Message-ID: References: <20171220072022.26909-1-palmer@dabbelt.com> <20171220072022.26909-4-palmer@dabbelt.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2017-12/txt/msg00744.txt.bz2 On Tue, 19 Dec 2017, Palmer Dabbelt wrote: > +extern ElfW(Addr) la_riscv_gnu_pltenter (ElfW(Sym) *__sym, unsigned int __ndx, With reference to my previous comments, ElfW is an exception to the rule of spaces before '(' in macro and function calls, because it locally expands to a single identifier. So this code is correct not to have a space there. > + extern ElfW(Addr) _GLOBAL_OFFSET_TABLE_ __attribute__((visibility("hidden"))); However, __attribute__ is *not* an exception. This should use: __attribute__ ((visibility ("hidden"))) - and likewise for other attributes, elsewhere in this patch or the patch series as a whole. General question in the area of this patch: static PIE support was recently added to glibc. Do you support it for RISC-V? It's not so far a requirement for adding a port, but if not supported, when the port goes in it would need adding to the list at of ports for which static PIE is not yet known to work. -- Joseph S. Myers joseph@codesourcery.com