From: Joseph Myers <joseph@codesourcery.com>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: <libc-alpha@sourceware.org>, <patches@groups.riscv.org>
Subject: Re: [PATCH v4 12/17] RISC-V: Linux Syscall Interface
Date: Mon, 15 Jan 2018 17:27:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1801151726100.26178@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20180113103816.4861-13-palmer@dabbelt.com>
On Sat, 13 Jan 2018, Palmer Dabbelt wrote:
> + if (INTERNAL_SYSCALL_ERROR_P (ret, err))
> + {
> + return __syscall_error (ret);
> + }
Generically, avoid redundant braces when there's only a single statement
inside "if".
> +# define internal_syscall2(number, err, arg0, arg1) \
> +({ \
> + long int _sys_result; \
> + \
> + { \
> + register long int __a7 asm ("a7") = number; \
> + register long int __a0 asm ("a0") = (long int) (arg0); \
> + register long int __a1 asm ("a1") = (long int) (arg1); \
> + __asm__ volatile ( \
> + "scall\n\t" \
> + : "+r" (__a0) \
> + : "r" (__a7), "r"(__a1) \
Missing space before '(' in asm constraint, ans likewise in other such
syscall macros.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2018-01-15 17:27 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-13 10:38 RISC-V glibc port, v4 Palmer Dabbelt
2018-01-13 10:38 ` [PATCH v4 02/17] Add RISC-V entries to config.h.in Palmer Dabbelt
2018-01-13 10:38 ` [PATCH v4 05/17] RISC-V: ABI Implementation Palmer Dabbelt
2018-01-15 16:51 ` Joseph Myers
2018-01-22 20:59 ` Palmer Dabbelt
2018-01-13 10:38 ` [PATCH v4 04/17] Add documentation for __riscv_flush_icache Palmer Dabbelt
2018-01-15 16:51 ` Joseph Myers
2018-01-22 20:14 ` [patches] " Palmer Dabbelt
2018-01-22 21:58 ` Joseph Myers
2018-01-23 2:31 ` Palmer Dabbelt
2018-01-23 17:34 ` Joseph Myers
2018-01-13 10:38 ` [PATCH v4 01/17] Skeleton documentation for the RISC-V port Palmer Dabbelt
2018-01-13 10:39 ` [PATCH v4 16/17] RISC-V: Build Infastructure Palmer Dabbelt
2018-01-15 17:44 ` Joseph Myers
2018-01-23 0:40 ` [patches] " Palmer Dabbelt
2018-01-23 0:55 ` Joseph Myers
2018-01-13 10:39 ` [PATCH v4 14/17] RISC-V: Linux Startup and Dynamic Loading Code Palmer Dabbelt
2018-01-13 10:39 ` [PATCH v4 13/17] RISC-V: Linux ABI Palmer Dabbelt
2018-01-15 17:37 ` Joseph Myers
2018-01-23 0:40 ` Palmer Dabbelt
2018-01-23 0:54 ` Joseph Myers
2018-01-13 10:39 ` [PATCH v4 07/17] RISC-V: Thread-Local Storage Support Palmer Dabbelt
2018-01-13 10:39 ` [PATCH v4 03/17] Add support for the RISC-V-specific ELF flags Palmer Dabbelt
2018-01-15 16:46 ` Joseph Myers
2018-01-15 16:51 ` Palmer Dabbelt
2018-01-13 10:39 ` [PATCH v4 11/17] RISC-V: Atomic and Locking Routines Palmer Dabbelt
2018-01-13 10:39 ` [PATCH v4 17/17] Add RISC-V to build-many-glibcs.py Palmer Dabbelt
2018-01-13 10:39 ` [PATCH v4 15/17] RISC-V: Add ABI Lists Palmer Dabbelt
2018-01-15 17:40 ` Joseph Myers
2018-01-23 0:40 ` Palmer Dabbelt
2018-01-13 10:39 ` [PATCH v4 09/17] RISC-V: RV32F Support Palmer Dabbelt
2018-01-13 10:39 ` [PATCH v4 06/17] RISC-V: Startup and Dynamic Loading Code Palmer Dabbelt
2018-01-15 16:55 ` Joseph Myers
2018-01-22 23:01 ` Palmer Dabbelt
2018-01-22 23:09 ` Joseph Myers
2018-01-23 3:32 ` Palmer Dabbelt
2018-01-13 10:39 ` [PATCH v4 08/17] RISC-V: Generic <math.h> and soft-fp Routines Palmer Dabbelt
2018-01-15 16:59 ` Joseph Myers
2018-01-22 23:16 ` [patches] " Palmer Dabbelt
2018-01-22 23:26 ` Joseph Myers
2018-01-23 3:40 ` Palmer Dabbelt
2018-01-13 10:39 ` [PATCH v4 10/17] RISC-V: RV32D, RV64F, and RV64D Support Palmer Dabbelt
2018-01-13 10:39 ` [PATCH v4 12/17] RISC-V: Linux Syscall Interface Palmer Dabbelt
2018-01-15 17:27 ` Joseph Myers [this message]
2018-01-23 0:40 ` [patches] " Palmer Dabbelt
2018-01-15 16:14 ` RISC-V glibc port, v4 Joseph Myers
2018-01-15 19:06 ` [patches] " Darius Rad
2018-01-15 20:47 ` Joseph Myers
2018-01-15 22:11 ` Darius Rad
2018-01-16 13:36 ` Darius Rad
2018-01-16 14:25 ` Joseph Myers
2018-01-17 2:01 ` Darius Rad
2018-01-22 20:14 ` Palmer Dabbelt
2018-01-22 21:51 ` Joseph Myers
2018-01-23 2:22 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1801151726100.26178@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=palmer@dabbelt.com \
--cc=patches@groups.riscv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).