From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89991 invoked by alias); 18 Jan 2018 23:16:09 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 89980 invoked by uid 89); 18 Jan 2018 23:16:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=postal X-HELO: relay1.mentorg.com Date: Thu, 18 Jan 2018 23:16:00 -0000 From: Joseph Myers To: Samuel Thibault CC: Thomas Schwinge , Florian Weimer , , GNU C Library Subject: Re: Upstreaming the glibc Hurd port In-Reply-To: <20180118165923.ymreisuzexxz4gt3@var.youpi.perso.aquilenet.fr> Message-ID: References: <20180118124537.yampmyfjsbi6wvia@var.youpi.perso.aquilenet.fr> <20180118135758.xqla2yevcrjjk7si@var.youpi.perso.aquilenet.fr> <87mv1btffy.fsf@hertz.schwinge.homeip.net> <20180118151446.zqlmpbmgg4kvs2y3@var.youpi.perso.aquilenet.fr> <20180118154251.ynfyugkmog7kujom@var.youpi.perso.aquilenet.fr> <20180118165923.ymreisuzexxz4gt3@var.youpi.perso.aquilenet.fr> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2018-01/txt/msg00646.txt.bz2 On Thu, 18 Jan 2018, Samuel Thibault wrote: > That's why I meant work is needed to sort out what we want to show > people. Which takes triaging time, back to square 0. I sent to the > bug-hurd list the list of patches which was enough at some point to get > glibc buildable, that's what should be worked on and what I plan to > commit to a single branch on the upstream repo. Thanks for the changes pushed to sthibaul/hurd-builds so far (I realise there will be more to get it into a buildable state, e.g. the actual libpthread implementation). General observations on mainly coding style issues that should be cleaned up for actual submission (there are also obvious issues with changes to non-Hurd-specific files needing cleaning up / justifying, which I didn't list individually): * Avoid __GNU__ conditionals in generic files (as per Roland's comments on the TLS patch). * Use -2018 in copyright notices. * There should be a descriptive comment on the first line of each file before the copyright notice. Where you have such comments, make sure they don't say something is a generic version when actually it's a Hurd-specific version. * Avoid FSF postal addresses in license notices; use a URL instead, as in existing files in glibc (using an https URL will avoid needing to be included in an http -> https fix for such URLs in future). * No "Contributed by" notices in new files. * verify.h should be LGPLv2.1+ for glibc use, but actually I think you should just use _Static_assert instead of verify.h, since the minimum compiler version for building glibc supports _Static_assert. * sysdeps/mach/hurd/gai_misc.h needs a copyright / license notice (and is missing spaces before '(' in some places). * In a few places, missing preprocessor indentation inside #if (as per , should be used except for a multiple include guard round a whole file). * Why are some symbols added in sysdeps/mach/hurd/bits/posix_opt.h with value 200112L, when 200809L corresponds to the POSIX version generally supported by glibc? -- Joseph S. Myers joseph@codesourcery.com