From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24631 invoked by alias); 19 Jan 2018 18:30:33 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 24560 invoked by uid 89); 19 Jan 2018 18:30:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Date: Fri, 19 Jan 2018 18:30:00 -0000 From: Joseph Myers To: Zack Weinberg CC: Thomas Schwinge , Florian Weimer , GNU C Library , , Samuel Thibault , David Michael Subject: Re: Upstreaming the glibc Hurd port In-Reply-To: Message-ID: References: <20180118124537.yampmyfjsbi6wvia@var.youpi.perso.aquilenet.fr> <20180118135758.xqla2yevcrjjk7si@var.youpi.perso.aquilenet.fr> <87mv1btffy.fsf@hertz.schwinge.homeip.net> <20180118151446.zqlmpbmgg4kvs2y3@var.youpi.perso.aquilenet.fr> <20180118154251.ynfyugkmog7kujom@var.youpi.perso.aquilenet.fr> <20180118165923.ymreisuzexxz4gt3@var.youpi.perso.aquilenet.fr> <20180118235924.r4z4ppvj7xlvmmfp@var.youpi.perso.aquilenet.fr> <87a7xaupjx.fsf@euler.schwinge.homeip.net> <877eseuefd.fsf@euler.schwinge.homeip.net> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2018-01/txt/msg00666.txt.bz2 On Fri, 19 Jan 2018, Zack Weinberg wrote: > On Fri, Jan 19, 2018 at 10:11 AM, Joseph Myers wrote: > > On Fri, 19 Jan 2018, Thomas Schwinge wrote: > > > > The source file sysdeps/mach/hurd/bits/errno.h is generated from sources > > including some headers from those components. I don't know how often > > those may change in ways that affect that header, or what versions the > > current header corresponds to, but in any case it's a known issue that > > there are several generated files in the source tree that > > build-many-glibcs.py doesn't yet touch on checkout. > > Note that there is no particularly good reason to have this file > checked in. It's generated with an awk script, and the files it's I'm not sure if having a non-checked-in generated file override another file in the source tree works correctly, the way a checked-in sysdeps file does override other files in the source tree. (sysdeps/gnu/errlist.c is another case of a sysdeps generated file - it needs to override stdio-common/errlist.c, and for that matter gets included by sysdeps/mach/hurd/errlist.c.) If the search orderings work correctly - both for finding files during the build, and for installing the correct bits/errno.h header (and the build-tree errlist.c can be properly included from the source-tree sysdeps/mach/hurd/errlist.c) - then there shouldn't be any need for either sysdeps/mach/hurd/bits/errno.h or sysdeps/gnu/errlist.c to be checked in. -- Joseph S. Myers joseph@codesourcery.com