From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126729 invoked by alias); 24 Jan 2018 01:26:52 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 126713 invoked by uid 89); 24 Jan 2018 01:26:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Date: Wed, 24 Jan 2018 01:26:00 -0000 From: Joseph Myers To: Samuel Thibault CC: Thomas Schwinge , Florian Weimer , GNU C Library , , David Michael Subject: Re: Upstreaming the glibc Hurd port In-Reply-To: <20180124011051.5s2vugyq3ybnurwc@var.youpi.perso.aquilenet.fr> Message-ID: References: <20180118151446.zqlmpbmgg4kvs2y3@var.youpi.perso.aquilenet.fr> <20180118154251.ynfyugkmog7kujom@var.youpi.perso.aquilenet.fr> <20180118165923.ymreisuzexxz4gt3@var.youpi.perso.aquilenet.fr> <20180118235924.r4z4ppvj7xlvmmfp@var.youpi.perso.aquilenet.fr> <87a7xaupjx.fsf@euler.schwinge.homeip.net> <20180124011051.5s2vugyq3ybnurwc@var.youpi.perso.aquilenet.fr> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2018-01/txt/msg00752.txt.bz2 On Wed, 24 Jan 2018, Samuel Thibault wrote: > Hello, > > Joseph Myers, on ven. 19 janv. 2018 17:23:29 +0000, wrote: > > Could Hurd people review how this handles building for Hurd, > > Yes, it looks good. Thanks, I've committed it to master. > > and indicate whether the above errors indicate problems with these > > changes, or simply incompleteness of the build support on the > > sthibaul/hurd-builds branch at present? > > They are not related to the changes. I have pushed fix updates against > them. Now I see errors about missing libc-lockP.h, and "implicit declaration of function '__spin_lock_solid'", and the discarded qualifiers errors you note below. > There is just one missing thing: mig prototypes etc. are not perfect, > and we thus have some nasty warnings about void * vs const void *. We'd > have to use > > if self.os == 'gnu': > cfg_cmd += ['MIG=%s' % self.tool_name('mig')] > + cfg_cmd += ['--disable-werror'] > > for now until we fix that. A properly upstreamed port should not need --disable-werror. If workarounds are needed until there's a fixed mig release (or whatever), they could take the form of explicit casts, or CFLAGS- += -Wno-error=discarded-qualifiers - disabling a particular warning being an error in a particular file is much better than globally disabling all warnings as errors. (Strictly -Wno-error=discarded-qualifiers shouldn't be used unconditionally since that warning option is new in GCC 5 and glibc supports building with GCC 4.9, but in the current state of the Hurd port I think we can ignore that in Hurd-specific Makefiles.) -- Joseph S. Myers joseph@codesourcery.com