From: Joseph Myers <joseph@codesourcery.com>
To: Romain Naour <romain.naour@gmail.com>
Cc: <libc-alpha@sourceware.org>
Subject: Re: glibc 2.27: less than two weeks till release
Date: Wed, 24 Jan 2018 22:02:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1801242200480.24303@digraph.polyomino.org.uk> (raw)
In-Reply-To: <f06ad9a2-8eaf-4368-d2ad-d1b6da20963f@gmail.com>
On Wed, 24 Jan 2018, Romain Naour wrote:
> > It looks like copy_file_range was only added for microblaze in 4.10
> > (commit 7181e5590e5ba898804aef3ee6be7f27606e6f8b). Which means the
> > definition of __ASSUME_COPY_FILE_RANGE is incorrect for microblaze - needs
> > an override in microblaze/kernel-features.h - and should be checked more
> > generally for all glibc architectures to determine the kernel versions in
> > which they had both the syscall table entry and the asm/unistd.h
> > definition.
> >
> So, __ASSUME_COPY_FILE_RANGE needs to be undefined for toolchain built with
> kernel-headers < 4.10, right ?
The microblaze/kernel-features.h needs to undefine
__ASSUME_COPY_FILE_RANGE under such a condition, yes, much like it handles
various other syscalls added later than on other architectures - but it
would be appropriate to make a check for all glibc architectures to see if
there are any others for which the default (>= 4.5) definition of
__ASSUME_COPY_FILE_RANGE is wrong.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2018-01-24 22:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 17:56 Dmitry V. Levin
2018-01-18 21:56 ` TODO: Alternative month names (was: Re: glibc 2.27: less than two weeks till release) Rafal Luzynski
2018-01-18 22:04 ` Zack Weinberg
2018-01-18 23:07 ` Rafal Luzynski
2018-01-19 8:51 ` TODO: Alternative month names Carlos O'Donell
2018-01-19 10:41 ` Rafal Luzynski
2018-01-19 8:54 ` glibc 2.27: less than two weeks till release Carlos O'Donell
2018-01-21 22:01 ` Romain Naour
2018-01-22 11:11 ` Szabolcs Nagy
2018-01-22 11:53 ` Adhemerval Zanella
2018-01-22 12:08 ` Szabolcs Nagy
2018-01-22 15:49 ` Joseph Myers
2018-01-22 16:00 ` Florian Weimer
2018-01-22 15:45 ` Joseph Myers
2018-01-24 21:57 ` Romain Naour
2018-01-24 22:02 ` Joseph Myers [this message]
2018-01-28 17:35 ` Romain Naour
2018-01-29 20:30 ` Joseph Myers
2018-01-30 0:21 ` Romain Naour
2018-01-30 1:01 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1801242200480.24303@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=romain.naour@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).