From: Joseph Myers <joseph@codesourcery.com>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: <libc-alpha@sourceware.org>, <patches@groups.riscv.org>,
Andrew Waterman <andrew@sifive.com>, <dj@redhat.com>,
Darius Rad <darius@bluespec.com>
Subject: Re: RISC-V glibc port, v6
Date: Fri, 26 Jan 2018 12:49:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1801261209310.14878@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20180126054443.22702-1-palmer@dabbelt.com>
On Thu, 25 Jan 2018, Palmer Dabbelt wrote:
> RV64IMAC/LP64 results:
>
> Summary of test results:
> 26 FAIL
> 5551 PASS
> 4 UNRESOLVED
> 18 UNSUPPORTED
> 18 XFAIL
>
> Test output [1].
>
> Includes ~9 expected cross test failures, ~5 timed out that should pass
> with a longer timeout. There are 3 failures due to rounding mode
> issues, tests that should be ignored due to soft float but are not. I
> will investigate more tomorrow.
>
> [1] http://bluespec.com/tmp/glibc-check-lp64.tar.xz
I see some warnings in those logs:
../sysdeps/riscv/math-tests.h:26:5: warning: "__riscv_flen" is not defined, evaluates to 0 [-Wundef]
#if __riscv_flen == 0
^~~~~~~~~~~~
(a) You're using --disable-werror to build glibc. Don't do that. It may
defeat the point of some tests (that operate at compile time and don't
test anything at runtime) that rely on errors for compilation warnings.
It may also defeat the rules about typo-proof macro conventions in glibc,
which only work with -Wundef warnings are errors.
(b) The source line in the error message is not part of the posted patch
series, i.e. these test logs don't seem to correspond to the posted
version of the port. The math-tests.h posted uses "#ifdef __riscv_flen",
twice (which is clearly inverted, you should have "#ifndef __riscv_flen",
twice, so see if using that avoids the rounding mode issues you mention),
not "#if __riscv_flen == 0"
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2018-01-26 12:17 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 5:44 Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 10/16] RISC-V: Atomic and Locking Routines Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 01/16] sysdeps/init_array: Add PREINIT_FUNCTION to crti.S Palmer Dabbelt
2018-01-26 12:56 ` Joseph Myers
2018-01-26 17:54 ` Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 16/16] Add RISC-V to build-many-glibcs.py Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 04/16] Add documentation for __riscv_flush_icache Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 15/16] RISC-V: Build Infastructure Palmer Dabbelt
2018-01-26 13:15 ` Joseph Myers
2018-01-26 18:00 ` Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 12/16] RISC-V: Linux ABI Palmer Dabbelt
2018-01-26 13:12 ` Joseph Myers
2018-01-26 18:05 ` Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 06/16] RISC-V: Startup and Dynamic Loading Code Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 02/16] Skeleton documentation for the RISC-V port Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 11/16] RISC-V: Linux Syscall Interface Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 03/16] Add RISC-V entries to config.h.in Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 05/16] RISC-V: ABI Implementation Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 08/16] RISC-V: Generic <math.h> and soft-fp Routines Palmer Dabbelt
2018-01-26 13:10 ` Joseph Myers
2018-01-26 18:03 ` Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 14/16] RISC-V: Add ABI Lists Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 07/16] RISC-V: Thread-Local Storage Support Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 09/16] RISC-V: Hard Float Support Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 13/16] RISC-V: Linux Startup and Dynamic Loading Code Palmer Dabbelt
2018-01-26 12:49 ` Joseph Myers [this message]
2018-01-26 17:51 ` RISC-V glibc port, v6 Palmer Dabbelt
2018-01-26 15:05 ` Joseph Myers
2018-01-26 18:18 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1801261209310.14878@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=andrew@sifive.com \
--cc=darius@bluespec.com \
--cc=dj@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=palmer@dabbelt.com \
--cc=patches@groups.riscv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).