From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-89609-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 120595 invoked by alias); 26 Jan 2018 12:26:31 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 120106 invoked by uid 89); 26 Jan 2018 12:26:30 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=H*Ad:U*patches
X-HELO: relay1.mentorg.com
Date: Fri, 26 Jan 2018 13:10:00 -0000
From: Joseph Myers <joseph@codesourcery.com>
To: Palmer Dabbelt <palmer@dabbelt.com>
CC: <libc-alpha@sourceware.org>, <patches@groups.riscv.org>, Andrew Waterman
	<andrew@sifive.com>, <dj@redhat.com>, Darius Rad <darius@bluespec.com>
Subject: Re: [PATCH v6 08/16] RISC-V: Generic <math.h> and soft-fp Routines
In-Reply-To: <20180126054443.22702-9-palmer@dabbelt.com>
Message-ID: <alpine.DEB.2.20.1801261225240.14878@digraph.polyomino.org.uk>
References: <20180126054443.22702-1-palmer@dabbelt.com> <20180126054443.22702-9-palmer@dabbelt.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To
 svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1)
X-SW-Source: 2018-01/txt/msg00913.txt.bz2

On Thu, 25 Jan 2018, Palmer Dabbelt wrote:

> +/* Despite not supporting trapping exceptions, we support setting
> +   floating-point exception flags on hard-float targets.  These are not
> +   supported on soft-float targets.  */
> +#ifdef __riscv_flen
> +# define EXCEPTION_TESTS_float 0
> +# define EXCEPTION_TESTS_double        0
> +# define EXCEPTION_TESTS_long_double   0
> +#endif
> +
> +/* On soft-float targets we only support the "to nearest" rounding mode.  */
> +#ifdef __riscv_flen
> +# define ROUNDING_TESTS_float(MODE)		((MODE) == FE_TONEAREST)
> +# define ROUNDING_TESTS_double(MODE)		((MODE) == FE_TONEAREST)
> +# define ROUNDING_TESTS_long_double(MODE)	((MODE) == FE_TONEAREST)
> +#endif

As noted, these should both be #ifndef, to disable those tests for soft 
float, whereas #ifdef would disable those tests for hard float.

-- 
Joseph S. Myers
joseph@codesourcery.com