From: Joseph Myers <joseph@codesourcery.com>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: <libc-alpha@sourceware.org>, <patches@groups.riscv.org>,
Andrew Waterman <andrew@sifive.com>, <dj@redhat.com>,
Darius Rad <darius@bluespec.com>
Subject: Re: RISC-V glibc port, v6
Date: Fri, 26 Jan 2018 15:05:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1801261257550.14878@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20180126054443.22702-1-palmer@dabbelt.com>
Version 6 is OK to commit with the fixes noted in the review, provided the
committed version builds and builds tests (for each of the supported
configurations) without --disable-werror and has at most 20
architecture-specific failures in each of those configurations.
The fixes noted in the review are, again:
* crti.S should follow pt-crti.S exactly for .section directive.
* Remove the <sys/asm.h> include in crti.S.
* Use #ifndef in math-tests.h, twice.
* Fix off-by-one errors in add_system_dir.
* Remove stray 32-bit ABI references in patch 15.
Note the following wiki updates required for adding a new port.
* Add yourself as maintainer in
<https://sourceware.org/glibc/wiki/MAINTAINERS>. For subsequent port
changes you'll need to say explicitly if you're looking for a review as
otherwise people will assume you aren't, but people may still point out
issues with port changes where you aren't looking for a review (being a
subsystem maintainer is only a shortcut for assuming consensus for your
changes to that subsystem, it does not guarantee there actually is
consensus).
* Update <https://sourceware.org/glibc/wiki/ABIList> to list all the
supported RISC-V ABIs (will need updating again in future if more
supported ABIs are added).
* Update <https://sourceware.org/glibc/wiki/PortStatus> to reflect any
features not handled for RISC-V (where there are list of architectures
lacking some feature), specifically static PIEs unless you've tested that
feature and determined it works.
* Update the <https://sourceware.org/glibc/wiki/Release/X.Y> template for
release wiki pages to include slots for RISC-V results for each supported
configuration.
* Add those slots to <https://sourceware.org/glibc/wiki/Release/2.27> as
well, and fill them in with test results before the release is out on 1
February. This will need doing for each subsequent release during the
one-month freeze period.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2018-01-26 13:10 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 5:44 Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 10/16] RISC-V: Atomic and Locking Routines Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 01/16] sysdeps/init_array: Add PREINIT_FUNCTION to crti.S Palmer Dabbelt
2018-01-26 12:56 ` Joseph Myers
2018-01-26 17:54 ` Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 04/16] Add documentation for __riscv_flush_icache Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 15/16] RISC-V: Build Infastructure Palmer Dabbelt
2018-01-26 13:15 ` Joseph Myers
2018-01-26 18:00 ` Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 16/16] Add RISC-V to build-many-glibcs.py Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 12/16] RISC-V: Linux ABI Palmer Dabbelt
2018-01-26 13:12 ` Joseph Myers
2018-01-26 18:05 ` Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 06/16] RISC-V: Startup and Dynamic Loading Code Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 02/16] Skeleton documentation for the RISC-V port Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 11/16] RISC-V: Linux Syscall Interface Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 03/16] Add RISC-V entries to config.h.in Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 05/16] RISC-V: ABI Implementation Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 14/16] RISC-V: Add ABI Lists Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 08/16] RISC-V: Generic <math.h> and soft-fp Routines Palmer Dabbelt
2018-01-26 13:10 ` Joseph Myers
2018-01-26 18:03 ` Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 07/16] RISC-V: Thread-Local Storage Support Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 09/16] RISC-V: Hard Float Support Palmer Dabbelt
2018-01-26 5:45 ` [PATCH v6 13/16] RISC-V: Linux Startup and Dynamic Loading Code Palmer Dabbelt
2018-01-26 12:49 ` RISC-V glibc port, v6 Joseph Myers
2018-01-26 17:51 ` Palmer Dabbelt
2018-01-26 15:05 ` Joseph Myers [this message]
2018-01-26 18:18 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1801261257550.14878@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=andrew@sifive.com \
--cc=darius@bluespec.com \
--cc=dj@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=palmer@dabbelt.com \
--cc=patches@groups.riscv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).