From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104628 invoked by alias); 26 Jan 2018 13:10:02 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 104585 invoked by uid 89); 26 Jan 2018 13:09:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=no version=3.3.2 spammy=H*Ad:U*patches X-HELO: relay1.mentorg.com Date: Fri, 26 Jan 2018 15:05:00 -0000 From: Joseph Myers To: Palmer Dabbelt CC: , , Andrew Waterman , , Darius Rad Subject: Re: RISC-V glibc port, v6 In-Reply-To: <20180126054443.22702-1-palmer@dabbelt.com> Message-ID: References: <20180126054443.22702-1-palmer@dabbelt.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2018-01/txt/msg00920.txt.bz2 Version 6 is OK to commit with the fixes noted in the review, provided the committed version builds and builds tests (for each of the supported configurations) without --disable-werror and has at most 20 architecture-specific failures in each of those configurations. The fixes noted in the review are, again: * crti.S should follow pt-crti.S exactly for .section directive. * Remove the include in crti.S. * Use #ifndef in math-tests.h, twice. * Fix off-by-one errors in add_system_dir. * Remove stray 32-bit ABI references in patch 15. Note the following wiki updates required for adding a new port. * Add yourself as maintainer in . For subsequent port changes you'll need to say explicitly if you're looking for a review as otherwise people will assume you aren't, but people may still point out issues with port changes where you aren't looking for a review (being a subsystem maintainer is only a shortcut for assuming consensus for your changes to that subsystem, it does not guarantee there actually is consensus). * Update to list all the supported RISC-V ABIs (will need updating again in future if more supported ABIs are added). * Update to reflect any features not handled for RISC-V (where there are list of architectures lacking some feature), specifically static PIEs unless you've tested that feature and determined it works. * Update the template for release wiki pages to include slots for RISC-V results for each supported configuration. * Add those slots to as well, and fill them in with test results before the release is out on 1 February. This will need doing for each subsequent release during the one-month freeze period. -- Joseph S. Myers joseph@codesourcery.com