From: Joseph Myers <joseph@codesourcery.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: <libc-alpha@sourceware.org>,
Jason Duerstock <jason.duerstock@gmail.com>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
James Clarke <jrtc27@jrtc27.com>
Subject: Re: RFC: remove the "tile" architecture from glibc
Date: Thu, 01 Feb 2018 13:39:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1802011329550.7786@digraph.polyomino.org.uk> (raw)
In-Reply-To: <0ebe0678-1eab-16ba-c461-2cfe517189bb@linaro.org>
On Thu, 1 Feb 2018, Adhemerval Zanella wrote:
> However the math tests seems to shows a lot of corner cases issues which
> has been fixed in generic implementations. As I commented with Jason Duerstock,
> John Paul Adrian, and James Clarke in a private thread I think easier solution
> for 2.28 is we remove the arch-specific faulty ia64 math implementation and
> use the generic ones. If performance is an issue we reimplement and fixed
> them if it is the case.
(a) Note that various functions don't have a generic ldbl-96
implementation, because all of x86_64, i386, ia64 and m68k have
architecture-specific implementations. So in those cases you can't simply
remove the ia64 implementation because there isn't an alternative one.
(b) Where the issue is just errno setting, that code is often in C rather
than ia64 assembly and so the existing implementation is probably easy to
fix - indeed, there is a patch (from 2009) attached to bug 10163 to fix
some such cases (including some where .S files are involved). I've not
checked whether that patch works, whether it applies to current sources,
whether any of the issues there are already fixed or whether it's correct,
but it's at least plausible for fixing some such bugs if it does indeed
eliminate failures for the affected functions without introducing
regressions.
(c) Of course, any fix, whether by removing an ia64-specific
implementation or by fixing it, should have a bug filed in Bugzilla first
stating what the actual bug is (we already have three such bugs).
(d) If you remove ia64-specific implementations you need to be careful not
to introduce __*_finite symbols at old symbol versions (the ia64
implementation doesn't have such symbols - it's probably not useful to add
them piecemeal without having an ia64 bits/math-finite.h that would use
them, but if added they should of course be at a new symbol version, not
the version where they were originally added for other architectures).
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2018-02-01 13:39 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 21:34 Chris Metcalf
2017-12-01 21:41 ` Joseph Myers
2017-12-01 21:57 ` John Paul Adrian Glaubitz
2017-12-01 22:11 ` Joseph Myers
2017-12-01 22:30 ` John Paul Adrian Glaubitz
2017-12-01 22:41 ` Joseph Myers
2017-12-02 15:15 ` John Paul Adrian Glaubitz
2017-12-04 11:10 ` Adhemerval Zanella
2017-12-04 11:28 ` John Paul Adrian Glaubitz
2017-12-04 18:03 ` Joseph Myers
2017-12-04 18:32 ` Adhemerval Zanella
2017-12-04 18:55 ` Joseph Myers
2017-12-04 18:14 ` Chris Metcalf
2017-12-04 18:36 ` Adhemerval Zanella
2017-12-04 17:53 ` Joseph Myers
2017-12-04 18:47 ` John Paul Adrian Glaubitz
2017-12-04 19:02 ` Joseph Myers
[not found] ` <alpine.DEB.2.20.1801311732001.23883@digraph.polyomino.org.uk>
[not found] ` <38170271-e17f-0a7e-7dd2-06fa6ddfae62@physik.fu-berlin.de>
2018-02-01 13:34 ` Adhemerval Zanella
2018-02-01 13:50 ` Joseph Myers
2018-02-01 16:50 ` Adhemerval Zanella
[not found] ` <9f8b994a-7085-e263-dd1b-bea2def55fb0@linaro.org>
2018-02-01 13:24 ` Adhemerval Zanella
2018-02-01 13:33 ` John Paul Adrian Glaubitz
2018-02-01 13:37 ` Adhemerval Zanella
2018-02-01 13:45 ` Joseph Myers
2018-02-01 16:40 ` Adhemerval Zanella
2018-02-01 13:39 ` Joseph Myers [this message]
2018-02-01 17:21 ` Adhemerval Zanella
2018-02-01 17:52 ` Joseph Myers
2018-02-01 18:30 ` Joseph Myers
2018-02-14 18:13 ` Joseph Myers
2017-12-02 1:15 ` Chris Metcalf
2017-12-02 15:16 ` John Paul Adrian Glaubitz
2017-12-04 21:49 ` Chris Metcalf
2017-12-04 23:29 ` Joseph Myers
2018-03-07 15:39 ` Arnd Bergmann
2018-03-07 16:01 ` Joseph Myers
2018-03-07 16:08 ` John Paul Adrian Glaubitz
2018-03-07 16:49 ` Adhemerval Zanella
2018-03-07 17:17 ` Joseph Myers
2018-03-07 18:16 ` Helmut Grohne
2018-03-08 15:55 ` Arnd Bergmann
2018-03-08 16:06 ` John Paul Adrian Glaubitz
2018-03-08 16:23 ` Arnd Bergmann
2018-03-09 16:31 ` Joseph Myers
2018-03-09 16:37 ` John Paul Adrian Glaubitz
2018-03-09 16:53 ` Joseph Myers
2018-03-08 17:14 ` Palmer Dabbelt
2018-03-08 23:36 ` Arnd Bergmann
2017-12-02 3:24 ` Carlos O'Donell
2017-12-08 16:20 ` Chris Metcalf
2018-01-05 9:01 ` Henrik Grindal Bakken
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1802011329550.7786@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=adhemerval.zanella@linaro.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=jason.duerstock@gmail.com \
--cc=jrtc27@jrtc27.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).