From: Joseph Myers <joseph@codesourcery.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [hurd,commited] hurd: do not check Mach and Hurd headers
Date: Sat, 03 Mar 2018 22:08:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1803032203400.17758@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20180303191852.19319-1-samuel.thibault@ens-lyon.org>
On Sat, 3 Mar 2018, Samuel Thibault wrote:
> as they are not standard.
That's not a sufficient reason for this change. What this script is
checking is nothing to do with whether the headers are standard; it's that
each header can be included in isolation with any supported feature test
macro defined (actually, just a few macros are tested) and in any C/C++
standards mode.
That property should apply to Hurd-specific headers installed by glibc
just as it applies to non-Hurd-specific headers (this script doesn't test
headers not installed by glibc). That is, any case of such a header
failing this test is presumptively a bug that should be fixed. (If a
header is in fact purely internal, not for direct use by users or by other
installed headers, stopping it being installed is the correct fix - this
test is specifically for installed headers. If a header is installed only
for use by other installed headers and is not meant to be included
directly by user programs, it should move into bits/; bits/ headers are
already excluded from this test.)
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2018-03-03 22:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-03 19:18 Samuel Thibault
2018-03-03 22:08 ` Joseph Myers [this message]
2018-03-03 22:32 ` Samuel Thibault
2018-03-03 22:53 ` Joseph Myers
2018-03-03 23:57 ` Samuel Thibault
2018-03-04 1:33 ` Joseph Myers
2018-03-04 1:35 ` Samuel Thibault
2018-03-04 1:41 ` Joseph Myers
2018-03-04 1:43 ` Samuel Thibault
2018-03-04 1:46 ` Joseph Myers
2018-03-04 1:46 ` Samuel Thibault
2018-03-04 0:32 ` Samuel Thibault
2018-03-04 1:28 ` Joseph Myers
2018-03-04 2:55 ` Samuel Thibault
2018-03-04 16:08 ` Zack Weinberg
2018-03-04 18:10 ` Samuel Thibault
2018-03-05 0:30 ` Zack Weinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1803032203400.17758@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).