From: Joseph Myers <joseph@codesourcery.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [hurd,commited] hurd: do not check Mach and Hurd headers
Date: Sun, 04 Mar 2018 01:33:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1803040129270.17758@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20180303235748.o67wmdwfd3a6xj3x@var.youpi.perso.aquilenet.fr>
On Sun, 4 Mar 2018, Samuel Thibault wrote:
> > But in any case where, after analysis, such a #error is found to
> > make sense (and a comment goes on the #error explaining why it
> > makes sense), that specific header might have testing disabled in
> > check-installed-headers.sh *only* when _GNU_SOURCE is not passed - not
> > for other feature test macros, not using wildcards like hurd/*.h.
>
> I have sent a patch adding support for this, and whitelisting mach
> headers, could you have a look?
It's not yet clear any such special cases in the script are needed. But
if they are, they would only be for specific headers that use #error
without __USE_GNU, not any wildcard such as hurd/*.h, and we should review
whether the #error usage is necessary or whether there's a better approach
in each particular case.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2018-03-04 1:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-03 19:18 Samuel Thibault
2018-03-03 22:08 ` Joseph Myers
2018-03-03 22:32 ` Samuel Thibault
2018-03-03 22:53 ` Joseph Myers
2018-03-03 23:57 ` Samuel Thibault
2018-03-04 1:33 ` Joseph Myers [this message]
2018-03-04 1:35 ` Samuel Thibault
2018-03-04 1:41 ` Joseph Myers
2018-03-04 1:43 ` Samuel Thibault
2018-03-04 1:46 ` Joseph Myers
2018-03-04 1:46 ` Samuel Thibault
2018-03-04 0:32 ` Samuel Thibault
2018-03-04 1:28 ` Joseph Myers
2018-03-04 2:55 ` Samuel Thibault
2018-03-04 16:08 ` Zack Weinberg
2018-03-04 18:10 ` Samuel Thibault
2018-03-05 0:30 ` Zack Weinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1803040129270.17758@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).