From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44160 invoked by alias); 15 Mar 2018 16:36:30 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 43744 invoked by uid 89); 15 Mar 2018 16:36:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Date: Thu, 15 Mar 2018 16:36:00 -0000 From: Joseph Myers To: "H.J. Lu" CC: Carlos O'Donell , "Tsimbalist, Igor V" , Florian Weimer , GNU C Library Subject: Re: [PATCH] x86: Add __sigsetjmp_cancel and __setjmp_cancel In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2018-03/txt/msg00378.txt.bz2 On Thu, 15 Mar 2018, H.J. Lu wrote: > +extern int __sigsetjmp_cancel (struct __jmp_buf_tag *__env, int __savemask) > + __THROWNL __attribute__((__returns_twice__)); I think you should define __attribute_returns_twice__ in misc/sys/cdefs.h (defined to empty if !__GNUC_PREREQ (4, 1)), then use it here. Missing space before '(' after __attribute__. -- Joseph S. Myers joseph@codesourcery.com