From: Joseph Myers <joseph@codesourcery.com>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
Cc: "libc-alpha@sourceware.org" <libc-alpha@sourceware.org>, nd <nd@arm.com>
Subject: Re: [PATCH v4 1/3] Cleanup __ieee754_sqrt(f/l)
Date: Thu, 15 Mar 2018 17:04:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1803151657510.26519@digraph.polyomino.org.uk> (raw)
In-Reply-To: <DB6PR0801MB2053657FD24E0CE67014E89883D00@DB6PR0801MB2053.eurprd08.prod.outlook.com>
On Thu, 15 Mar 2018, Wilco Dijkstra wrote:
> 2018-03-15 Wilco Dijkstra <wdijkstr@arm.com>
>
> * include/math.h (sqrt): Declare with asm redirect.
> (sqrtf): Likewise.
> (sqrtl): Likewise.
> (sqrtf128): Likewise.
> * Makeconfig: Add -fno-math-errno for libc/libm, but build testsuite,
> nonlib and libnldbl with -fmath-errno.
> * math/w_sqrt_compat.c: Define NO_MATH_REDIRECT.
> * math/w_sqrt_template.c: Likewise.
> * math/w_sqrtf_compat.c: Likewise.
> * math/w_sqrtl_compat.c: Likewise.
> * sysdeps/generic/math-type-macros-float128.h: Remove math.h and complex.h.
> * sysdeps/i386/fpu/w_sqrt.c: Likewise.
> * sysdeps/i386/fpu/w_sqrt_compat.c: Likewise.
The sysdeps/generic/math-type-macros-float128.h entry should come at the
end, otherwise the "Likewise" for the subsequent two files is incorrect,
since it's not math.h and complex.h includes being removed from them, it's
NO_MATH_REDIRECT defines being added.
> +# if !(defined __FINITE_MATH_ONLY__ && __FINITE_MATH_ONLY__ > 0)
> +# ifndef NO_MATH_REDIRECT
> +/* Declare sqrt for use within GLIBC. Sqrt will typically inline into a
sqrt not Sqrt at the start of a sentence (see the GNU Coding Standards:
"If a lower-case identifier comes at the beginning of a sentence, don't
capitalize it! Changing the spelling makes it a different identifier.
If you don't like starting a sentence with a lower case letter, write the
sentence differently (e.g., ``The identifier lower-case is @dots{}'').").
This patch is OK with those changes.
--
Joseph S. Myers
joseph@codesourcery.com
prev parent reply other threads:[~2018-03-15 17:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 15:53 Wilco Dijkstra
2018-03-15 17:04 ` Joseph Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1803151657510.26519@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=Wilco.Dijkstra@arm.com \
--cc=libc-alpha@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).