From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39262 invoked by alias); 15 Mar 2018 17:04:15 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 39243 invoked by uid 89); 15 Mar 2018 17:04:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Date: Thu, 15 Mar 2018 17:04:00 -0000 From: Joseph Myers To: Wilco Dijkstra CC: "libc-alpha@sourceware.org" , nd Subject: Re: [PATCH v4 1/3] Cleanup __ieee754_sqrt(f/l) In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2018-03/txt/msg00380.txt.bz2 On Thu, 15 Mar 2018, Wilco Dijkstra wrote: > 2018-03-15 Wilco Dijkstra > > * include/math.h (sqrt): Declare with asm redirect. > (sqrtf): Likewise. > (sqrtl): Likewise. > (sqrtf128): Likewise. > * Makeconfig: Add -fno-math-errno for libc/libm, but build testsuite, > nonlib and libnldbl with -fmath-errno. > * math/w_sqrt_compat.c: Define NO_MATH_REDIRECT. > * math/w_sqrt_template.c: Likewise. > * math/w_sqrtf_compat.c: Likewise. > * math/w_sqrtl_compat.c: Likewise. > * sysdeps/generic/math-type-macros-float128.h: Remove math.h and complex.h. > * sysdeps/i386/fpu/w_sqrt.c: Likewise. > * sysdeps/i386/fpu/w_sqrt_compat.c: Likewise. The sysdeps/generic/math-type-macros-float128.h entry should come at the end, otherwise the "Likewise" for the subsequent two files is incorrect, since it's not math.h and complex.h includes being removed from them, it's NO_MATH_REDIRECT defines being added. > +# if !(defined __FINITE_MATH_ONLY__ && __FINITE_MATH_ONLY__ > 0) > +# ifndef NO_MATH_REDIRECT > +/* Declare sqrt for use within GLIBC. Sqrt will typically inline into a sqrt not Sqrt at the start of a sentence (see the GNU Coding Standards: "If a lower-case identifier comes at the beginning of a sentence, don't capitalize it! Changing the spelling makes it a different identifier. If you don't like starting a sentence with a lower case letter, write the sentence differently (e.g., ``The identifier lower-case is @dots{}'')."). This patch is OK with those changes. -- Joseph S. Myers joseph@codesourcery.com