From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103378 invoked by alias); 19 Mar 2018 16:43:08 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 103362 invoked by uid 89); 19 Mar 2018 16:43:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Date: Mon, 19 Mar 2018 16:43:00 -0000 From: Joseph Myers To: Samuel Thibault CC: Subject: Re: [hurd,commited] hurd: Replace threadvars with TLS In-Reply-To: <20180317223049.11865-1-samuel.thibault@ens-lyon.org> Message-ID: References: <20180317223049.11865-1-samuel.thibault@ens-lyon.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2018-03/txt/msg00463.txt.bz2 On Sat, 17 Mar 2018, Samuel Thibault wrote: > diff --git a/sysdeps/mach/hurd/errno-loc.c b/sysdeps/mach/hurd/errno-loc.c > index 7b1e7ce347..95d0fe47c4 100644 > --- a/sysdeps/mach/hurd/errno-loc.c > +++ b/sysdeps/mach/hurd/errno-loc.c > @@ -16,13 +16,21 @@ > License along with the GNU C Library; if not, see > . */ > > -#include > -#include > - > -int * > +#if IS_IN (rtld) > +/* > + * rtld can not access TLS too early, thus rtld_errno. > + * > + * Instead of making __open/__close pass errno from TLS to rtld_errno, simply > + * use a weak __errno_location using rtld_errno, which will be overriden by the > + * libc definition. > + */ We don't use leading '*' on each line of comments. -- Joseph S. Myers joseph@codesourcery.com