public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Joseph Myers <joseph@codesourcery.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Replace strncpy with memccpy to fix -Wstringop-truncation.
Date: Fri, 23 Mar 2018 01:17:00 -0000	[thread overview]
Message-ID: <alpine.DEB.2.20.1803230115280.6153@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20180323010729.41457-1-raj.khem@gmail.com>

On Thu, 22 Mar 2018, Khem Raj wrote:

> 	* nis/nss_nisplus/nisplus-parser.c: Replace strncpy with memcpy to
> 	avoid -Wstringop-truncation.

Could you give more details of (a) in what circumstances (architecture, 
compiler, etc.) you get this warning and (b) why the truncation is 
correct?

Whatever build failure you got hasn't shown up with build-many-glibcs.py.  
Maybe that should include a configuration with --enable-obsolete-rpc 
--enable-obsolete-nsl to make sure that it tests building those bits of 
code that are disabled by default?

-- 
Joseph S. Myers
joseph@codesourcery.com

  reply	other threads:[~2018-03-23  1:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-23  1:07 Khem Raj
2018-03-23  1:17 ` Joseph Myers [this message]
2018-03-23  1:30   ` Khem Raj
2018-04-05 15:57     ` Stefan Liebler
2018-04-05 16:14       ` Andreas Schwab
2018-04-12 15:31         ` Stefan Liebler
2018-04-19 14:30           ` Stefan Liebler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1803230115280.6153@digraph.polyomino.org.uk \
    --to=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).