From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18336 invoked by alias); 3 Apr 2018 00:13:51 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 18315 invoked by uid 89); 3 Apr 2018 00:13:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=naturally X-HELO: relay1.mentorg.com Date: Tue, 03 Apr 2018 00:13:00 -0000 From: Joseph Myers To: Samuel Thibault CC: Florian Weimer , Thomas Schwinge , GNU C Library , , David Michael Subject: Re: Upstreaming the glibc Hurd port In-Reply-To: <20180402161347.e5nx7cdt7pkgx52u@var.youpi.perso.aquilenet.fr> Message-ID: References: <87a7xaupjx.fsf@euler.schwinge.homeip.net> <20180124011051.5s2vugyq3ybnurwc@var.youpi.perso.aquilenet.fr> <20180124012726.tibylwp4re5dtgc3@var.youpi.perso.aquilenet.fr> <20180125014143.2hxhzon5lzxtqq6j@var.youpi.perso.aquilenet.fr> <20180319015122.j5tzslkdcnvampoh@var.youpi.perso.aquilenet.fr> <20180402001003.3u5n2p5pdmv4hos5@var.youpi.perso.aquilenet.fr> <20180402155017.iermidp5siqgcixv@var.youpi.perso.aquilenet.fr> <20180402161347.e5nx7cdt7pkgx52u@var.youpi.perso.aquilenet.fr> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-02.mgc.mentorg.com (139.181.222.2) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2018-04/txt/msg00043.txt.bz2 On Mon, 2 Apr 2018, Samuel Thibault wrote: > Samuel Thibault, on lun. 02 avril 2018 17:50:17 +0200, wrote: > > There are a few remaining namespace issues due to missing __ marking or > > spurious #includes. > > One issue is with struct sched_param. The __sched_param definition > was removed in glibc while htl's pthread_attr uses it. For now I just > made struct___pthread_attr.h include but that brings things > unwanted for (which is supposed to pull pthread_attr). > > So I guess we should revert to defining __sched_param? If you need, on Hurd, in installed headers, a type "struct __sched_param", that would most naturally go in a Hurd-specific bits/types/struct___sched_param.h. If that's not appropriate, please explain the issue in more detail. Anything restoring the old __need_* mechanism for any glibc-internal definitions is not appropriate (struct __sched_param was removed as part of removing __need_*). -- Joseph S. Myers joseph@codesourcery.com