From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26546 invoked by alias); 3 Apr 2018 00:17:47 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 26537 invoked by uid 89); 3 Apr 2018 00:17:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Date: Tue, 03 Apr 2018 00:17:00 -0000 From: Joseph Myers To: Samuel Thibault CC: Subject: Re: [hurd,commited] hurd: Avoid some PLTs in libc and librt In-Reply-To: <20180402190912.1666-1-samuel.thibault@ens-lyon.org> Message-ID: References: <20180402190912.1666-1-samuel.thibault@ens-lyon.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2018-04/txt/msg00044.txt.bz2 As a general matter, calling __foo instead of foo is something done for namespace reasons, if there is a standard namespace (or, in principle, one such as _DEFAULT_SOURCE, though we don't test that) including a function in the calling file, but not foo. It may also fix local PLT issues, if __foo is not exported from the library in question, but if there are only PLT issues not namespace ones, the *_hidden_proto / *_hidden_def macros would typically be called as a sufficient solution to the PLT issues. Calling __foo does of course introduce the need for declarations of __foo that may not have been previously needed, and those may need to replicate properties of the public declarations of foo, such as attributes or the presence of inline versions, to avoid regressions. -- Joseph S. Myers joseph@codesourcery.com