From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24559 invoked by alias); 17 Apr 2018 21:01:22 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 24488 invoked by uid 89); 17 Apr 2018 21:01:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Date: Tue, 17 Apr 2018 21:01:00 -0000 From: Joseph Myers To: Paul Pluzhnikov CC: GLIBC Devel Subject: Re: [patch] Fix path length overflow in realpath (BZ#22786) In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2018-04/txt/msg00289.txt.bz2 On Mon, 9 Apr 2018, Paul Pluzhnikov wrote: > +# suppress warnings about allocation size. > +CFLAGS-test-bz22786.c += $(+gcc-nowarn) I see no current uses of $(+gcc-nowarn) in the source tree. Rather than resurrecting this variable, we should remove it. Warnings should be disabled as locally as possible in the sources - meaning using DIAG_* with appropriate detailed comments around the specific statements generating warnings, if possible, and failing that, with specific -Wno-* options in the makefile rather than the extremely blunt -w which would also hide all valid warnings, not just the one warning you intend to avoid on the one bit of code for which you intend to avoid it. -- Joseph S. Myers joseph@codesourcery.com