From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50322 invoked by alias); 8 May 2018 14:49:40 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 50309 invoked by uid 89); 8 May 2018 14:49:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=Hx-languages-length:1089, nds32, D*codesourcery.com X-HELO: relay1.mentorg.com Date: Tue, 08 May 2018 14:49:00 -0000 From: Joseph Myers To: vincentc CC: , , Subject: Re: [PATCH 01/11] nds32: Build Infastructure In-Reply-To: <1525617685-32083-2-git-send-email-vincentc@andestech.com> Message-ID: References: <1525617685-32083-1-git-send-email-vincentc@andestech.com> <1525617685-32083-2-git-send-email-vincentc@andestech.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2018-05/txt/msg00277.txt.bz2 On Sun, 6 May 2018, vincentc wrote: > diff --git a/sysdeps/nds32/configure.ac b/sysdeps/nds32/configure.ac > new file mode 100644 > index 0000000..4ca57b8 > --- /dev/null > +++ b/sysdeps/nds32/configure.ac > @@ -0,0 +1,14 @@ > +GLIBC_PROVIDES dnl See aclocal.m4 in the top level source directory. > +# Local configure fragment for sysdeps/nds32. > +CFLAGS="$CFLAGS -minline-asm-r15" If that option is needed globally for building glibc, a comment should be there to explain it. > +AC_CACHE_CHECK(whether gcc support option -mno-scalbn-transform, > + libc_cv_scalbn_transform, [dnl > +save_CFLAGS="$CFLAGS" > +CFLAGS="$CFLAGS -mno-scalbn-transform" What does this option do (I don't see it in current GCC)? Since you've said current GCC versions aren't suitable for building glibc, can't you just require a compiler supporting the option, unconditionally, so any test for it is just to ensure a configure error for a too-old compiler rather than allowing compilation to continue without support? -- Joseph S. Myers joseph@codesourcery.com