From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66901 invoked by alias); 31 May 2018 21:44:25 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 66886 invoked by uid 89); 31 May 2018 21:44:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Date: Thu, 31 May 2018 21:44:00 -0000 From: Joseph Myers To: Vincent Chen CC: , , Subject: Re: [PATCH v2 05/12] nds32: Generic and soft-fp Routines In-Reply-To: <1527677142-10406-6-git-send-email-vincentc@andestech.com> Message-ID: References: <1527677142-10406-1-git-send-email-vincentc@andestech.com> <1527677142-10406-6-git-send-email-vincentc@andestech.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2018-05/txt/msg00895.txt.bz2 On Wed, 30 May 2018, Vincent Chen wrote: > + FE_TONEAREST = > +#define FE_TONEAREST 1 > + FE_TONEAREST, > + }; As noted in RISC-V port review, C90 / C++98 don't support trailing commas in enum definitions, so you shouldn't have a comma after the last element of an enum defined in an installed header. -- Joseph S. Myers joseph@codesourcery.com