From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111285 invoked by alias); 6 Jun 2018 23:05:18 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 109457 invoked by uid 89); 6 Jun 2018 23:05:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=justify, carefully, reserved X-HELO: relay1.mentorg.com Date: Wed, 06 Jun 2018 23:05:00 -0000 From: Joseph Myers To: Tulio Magno Quites Machado Filho CC: , , Subject: Re: [PATCH 1/9] ldbl-128ibm-compat: Create libm-alias-float128.h In-Reply-To: <20180606223909.16675-2-tuliom@linux.ibm.com> Message-ID: References: <20180606223909.16675-1-tuliom@linux.ibm.com> <20180606223909.16675-2-tuliom@linux.ibm.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2018-06/txt/msg00128.txt.bz2 On Wed, 6 Jun 2018, Tulio Magno Quites Machado Filho wrote: > + __f32addieee128; > + __f32divieee128; > + __f32mulieee128; > + __f32subieee128; > + __f64addieee128; > + __f64divieee128; > + __f64mulieee128; > + __f64subieee128; > + __f64xaddieee128; > + __f64xdivieee128; > + __f64xmulieee128; > + __f64xsubieee128; The __f64x* functions shouldn't be needed here. The __f32* and __f64* ones seem appropriate (for faddl / daddl etc. redirection), but in patch 8 you appear to be redirecting instead to the f32* / f64* functions (only reserved in TS 18661-3, not in TS 18661-1). > + __gamma_productieee128; __gamma_product is an internal part of libm, not a public exported function. You should start from the *f128 functions that are actually exported from libm, and justify any additions to that set carefully (generally as functions that are part of the long double API and so need *ieee128 versions). > + __lgamma_negieee128; > + __lgamma_productieee128; Again, these are internal implementation details, not exported functions. > + __x2y2m1ieee128; Likewise. -- Joseph S. Myers joseph@codesourcery.com