From: Joseph Myers <joseph@codesourcery.com>
To: Albert ARIBAUD <albert.aribaud@3adev.fr>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH 0/2] Y2038 support batch 1 - __time64_t and __tz_convert
Date: Wed, 13 Jun 2018 14:08:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1806131405560.28522@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20180613095858.55d56502@athena>
On Wed, 13 Jun 2018, Albert ARIBAUD wrote:
> These patches have also been tested using build-many-glibcs.py, always
> for x86_64, aarch64, arm and powerpc compilers, and regularly for all
> compilers, and found to give the same results as those of the current
> glibc master above which the patches were created.
Since build-many-glibcs.py should give clean results everywhere except
i686-gnu, and since this patch adds Versions entries at a public ABI
version but has no *.abilist updates, I'm skeptical of the above
description of testing. You should have no ABI test failures before the
patch series, anywhere, whether in your normal ARM testing or with
build-many-glibcs.py, and without *.abilist updates you should be seeing
such failures after the patch series.
Any patch adding new ABIs at public versions always needs to include the
ABI baseline updates for *all* glibc configurations.
You should do full execution testing for at least one 64-bit
configuration, as well.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2018-06-13 14:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 7:00 Albert ARIBAUD (3ADEV)
2018-06-13 7:00 ` [PATCH 1/2] Y2038: add type __time64_t Albert ARIBAUD (3ADEV)
2018-06-13 8:38 ` Paul Eggert
2018-06-13 12:36 ` Albert ARIBAUD
2018-06-13 14:13 ` Joseph Myers
2018-06-13 16:19 ` Albert ARIBAUD
2018-06-13 16:35 ` Paul Eggert
2018-06-13 16:39 ` Joseph Myers
2018-06-13 18:46 ` Paul Eggert
2018-06-13 7:00 ` [PATCH 2/2] Y2038: make __tz_convert compatible with 64-bit-time Albert ARIBAUD (3ADEV)
2018-06-13 9:10 ` Florian Weimer
2018-06-13 9:37 ` Albert ARIBAUD
2018-06-13 9:40 ` Florian Weimer
2018-06-13 10:21 ` Albert ARIBAUD
2018-06-13 10:55 ` Albert ARIBAUD
2018-06-13 13:08 ` Florian Weimer
2018-06-13 14:29 ` Joseph Myers
2018-06-13 14:24 ` Joseph Myers
2018-06-18 13:34 ` Florian Weimer
2018-06-13 9:11 ` Paul Eggert
2018-06-13 9:14 ` Florian Weimer
2018-06-13 9:30 ` Albert ARIBAUD
2018-06-13 14:22 ` Joseph Myers
2018-06-13 14:18 ` Joseph Myers
2018-06-13 7:59 ` [PATCH 0/2] Y2038 support batch 1 - __time64_t and __tz_convert Albert ARIBAUD
2018-06-13 14:08 ` Joseph Myers [this message]
2018-06-13 15:38 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1806131405560.28522@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=albert.aribaud@3adev.fr \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).