From: Joseph Myers <joseph@codesourcery.com>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: "Albert ARIBAUD (3ADEV)" <albert.aribaud@3adev.fr>,
<libc-alpha@sourceware.org>
Subject: Re: [PATCH 2/2] Y2038: make __tz_convert compatible with 64-bit-time
Date: Wed, 13 Jun 2018 14:22:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1806131419040.28522@digraph.polyomino.org.uk> (raw)
In-Reply-To: <14097bbd-ab4c-aec7-f532-23418a120b69@cs.ucla.edu>
On Wed, 13 Jun 2018, Paul Eggert wrote:
> I don't see why 64-bit platforms need two entry points. If time_t is 64 bits,
> ctime and __ctime64 can be aliases, no? Also, it's a bit cleaner to declare
> and initialize t64 at the same time, i.e., '__time64_t t64 = *t;'; we can
> assume this C99ism in glibc nowadays.
My suggestion is that an internal header does
#if !__TIME32_SUPPORTED
# define __ctime64 ctime
#endif
and then the definition of the 32-bit ctime wrapper is conditional on "#if
__TIME32_SUPPORTED", so that the main 64-bit version just gets compiled as
ctime in the case where time_t has always only been 64-bit for this ABI.
That way, internal code can call the __*64 interfaces unconditionally and
the calls will just end up calling the non-*64 interfaces when the *64
interfaces don't need to exist as separate functions - and no exports of
*64 in the public ABI are needed in that case either.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2018-06-13 14:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 7:00 [PATCH 0/2] Y2038 support batch 1 - __time64_t and __tz_convert Albert ARIBAUD (3ADEV)
2018-06-13 7:00 ` [PATCH 2/2] Y2038: make __tz_convert compatible with 64-bit-time Albert ARIBAUD (3ADEV)
2018-06-13 9:10 ` Florian Weimer
2018-06-13 9:37 ` Albert ARIBAUD
2018-06-13 9:40 ` Florian Weimer
2018-06-13 10:21 ` Albert ARIBAUD
2018-06-13 10:55 ` Albert ARIBAUD
2018-06-13 13:08 ` Florian Weimer
2018-06-13 14:29 ` Joseph Myers
2018-06-13 14:24 ` Joseph Myers
2018-06-18 13:34 ` Florian Weimer
2018-06-13 9:11 ` Paul Eggert
2018-06-13 9:14 ` Florian Weimer
2018-06-13 9:30 ` Albert ARIBAUD
2018-06-13 14:22 ` Joseph Myers [this message]
2018-06-13 14:18 ` Joseph Myers
2018-06-13 7:00 ` [PATCH 1/2] Y2038: add type __time64_t Albert ARIBAUD (3ADEV)
2018-06-13 8:38 ` Paul Eggert
2018-06-13 12:36 ` Albert ARIBAUD
2018-06-13 14:13 ` Joseph Myers
2018-06-13 16:19 ` Albert ARIBAUD
2018-06-13 16:35 ` Paul Eggert
2018-06-13 16:39 ` Joseph Myers
2018-06-13 18:46 ` Paul Eggert
2018-06-13 7:59 ` [PATCH 0/2] Y2038 support batch 1 - __time64_t and __tz_convert Albert ARIBAUD
2018-06-13 14:08 ` Joseph Myers
2018-06-13 15:38 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1806131419040.28522@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=albert.aribaud@3adev.fr \
--cc=eggert@cs.ucla.edu \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).