From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14532 invoked by alias); 18 Jun 2018 14:54:44 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 14522 invoked by uid 89); 18 Jun 2018 14:54:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Date: Mon, 18 Jun 2018 14:54:00 -0000 From: Joseph Myers To: "Albert ARIBAUD (3ADEV)" CC: Subject: Re: [PATCH v4 1/2] Y2038: Add 64-bit time for all architectures In-Reply-To: <20180618135946.2969-2-albert.aribaud@3adev.fr> Message-ID: References: <20180618135946.2969-1-albert.aribaud@3adev.fr> <20180618135946.2969-2-albert.aribaud@3adev.fr> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2018-06/txt/msg00492.txt.bz2 On Mon, 18 Jun 2018, Albert ARIBAUD (3ADEV) wrote: > sysdeps/x86_64/x32/bits/timesize.h | 21 ++++++++++++++++ > sysdeps/x86_64/x32/bits/timesizes.h | 32 +++++++++++++++++++++++++ (a) The different choice of time_t is specific to x32 *with the Linux kernel* and so should go in a Linux-specific sysdeps directory. (b) For installed headers, a single header needs to handle all the different multilibs that can use a single compiler. That is, just as sysdeps/unix/sysv/linux/x86/bits/typesizes.h handles all of i386, x86_64 and x32, so these headers also need to be in sysdeps/unix/sysv/linux/x86/bits/ and contain conditionals for x32 (defined __x86_64__ && defined __ILP32__) to determine the definitions to use. You can't use e.g. x32-specific directories for installed headers, only for other implementation files. -- Joseph S. Myers joseph@codesourcery.com