From: Joseph Myers <joseph@codesourcery.com>
To: "Albert ARIBAUD (3ADEV)" <albert.aribaud@3adev.fr>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH 1/1] Y2038: make __mktime_internal compatible with 64-bit-time
Date: Tue, 19 Jun 2018 12:22:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1806191220130.27999@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20180619121626.24902-2-albert.aribaud@3adev.fr>
On Tue, 19 Jun 2018, Albert ARIBAUD (3ADEV) wrote:
> if (TIME_T_MAX / INT_MAX / 366 / 24 / 60 / 60 < 3)
> {
> - /* time_t isn't large enough to rule out overflows, so check
> - for major overflows. A gross check suffices, since if t0
> + /* __time64_t is large enough to rule out overflows, but check
> + for major overflows anyway. A gross check suffices, since if t0
Are you sure it's coherent to have code in this file using a TIME_T_MAX
that's defined in terms of time_t, when the code is using __time64_t? I'd
expect you to need to define TIME_T_MAX and TIME_T_MIN in terms of
__time64_t instead.
> + __set_errno(EOVERFLOW);
Missing space before '('. You need to watch out for such issues
throughout the patch series.
> + __set_errno(EOVERFLOW);
Likewise.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2018-06-19 12:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 12:16 [PATCH 0/1] Y2038 support batch 2 - __mktime_internal Albert ARIBAUD (3ADEV)
2018-06-19 12:16 ` [PATCH 1/1] Y2038: make __mktime_internal compatible with 64-bit-time Albert ARIBAUD (3ADEV)
2018-06-19 12:22 ` Joseph Myers [this message]
2018-06-19 16:32 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1806191220130.27999@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=albert.aribaud@3adev.fr \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).