From: Joseph Myers <joseph@codesourcery.com>
To: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH 12/12] ldbl-128ibm-compat: Provide ieee128 symbols to narrow functions
Date: Wed, 20 Jun 2018 10:55:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1806201049210.3953@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20180620020426.20372-13-tuliom@linux.ibm.com>
On Wed, 20 Jun 2018, Tulio Magno Quites Machado Filho wrote:
> Add ieee128 aliases for faddl, fdivl, fmull, fsubl, daddl, ddivl, dmull, dsubl.
>
> 2018-06-19 Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
>
> * math/math-narrow.h [__HAVE_DISTINCT_FLOAT128 &&
> !__HAVE_FLOAT128_UNLIKE_LDBL] (libm_alias_float32_float128,
I don't think __HAVE_FLOAT128_UNLIKE_LDBL is logically right here. That's
about the current compilation, i.e. about whether these particular files
end up getting built with IEEE long double. I don't know what files in
the source tree might end up getting built with what long double setting,
but it shouldn't matter for these files whether they are built with IEEE
long double or not.
Your property is something different, "glibc has *ieee128 aliases for
_Float128 functions" (a property of the glibc configuration, not of the
current compilation, but a different property from
__HAVE_DISTINCT_FLOAT128). That suggests to me that either you need some
new macro tested by this file, or you need e.g.
math-narrow-alias-float128.h (included by math-narrow.h) which contains
these float128 alias macros and for which ldbl-128ibm-compat provides a
different version.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2018-06-20 10:55 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 2:04 [PATCHv2 00/12] Introduce ieee128 symbols and redirections Tulio Magno Quites Machado Filho
2018-06-20 2:05 ` [PATCH 01/12] Undefine redirections after long double definition on __LDBL_COMPAT [BZ #23294] Tulio Magno Quites Machado Filho
2018-06-20 10:38 ` Joseph Myers
2018-06-20 2:05 ` [PATCH 06/12] ldbl-128ibm-compat: Create libm-alias-float128.h Tulio Magno Quites Machado Filho
2018-06-20 20:39 ` Joseph Myers
2018-06-20 22:03 ` Tulio Magno Quites Machado Filho
2018-06-20 2:05 ` [PATCH 07/12] ldbl-128ibm-compat: Provide a scalb implementation Tulio Magno Quites Machado Filho
2018-06-20 20:40 ` Joseph Myers
2018-06-20 2:05 ` [PATCH 04/12] Add a generic significand implementation Tulio Magno Quites Machado Filho
2018-06-20 20:34 ` Joseph Myers
2018-06-20 21:31 ` Tulio Magno Quites Machado Filho
2018-06-21 17:01 ` Joseph Myers
2018-06-22 21:33 ` [PATCH] m68k: Reorganize log1p and significand implementations Tulio Magno Quites Machado Filho
2018-06-22 21:34 ` Jeff Law
2018-06-22 21:54 ` Joseph Myers
2018-06-20 2:05 ` [PATCH 05/12] Refactor math/bits/math-finite.h, reusing math/bits/mathcalls.h [BZ #23292] Tulio Magno Quites Machado Filho
2018-06-20 10:41 ` Joseph Myers
2018-06-20 2:05 ` [PATCH 02/12] Move declare_mgen_finite_alias definition Tulio Magno Quites Machado Filho
2018-06-20 10:39 ` Joseph Myers
2018-06-20 13:14 ` Tulio Magno Quites Machado Filho
2018-06-20 21:04 ` Joseph Myers
2018-06-20 21:09 ` Tulio Magno Quites Machado Filho
2018-06-20 2:05 ` [PATCH 03/12] Add a generic scalb implementation Tulio Magno Quites Machado Filho
2018-06-20 20:32 ` Joseph Myers
2018-06-20 22:19 ` Tulio Magno Quites Machado Filho
2018-06-20 22:24 ` Joseph Myers
2018-06-20 2:06 ` [PATCH 11/12] ldbl-128ibm-compat: Redirect complex math functions Tulio Magno Quites Machado Filho
2018-06-20 21:00 ` Joseph Myers
2018-06-21 19:05 ` Tulio Magno Quites Machado Filho
2018-06-20 2:06 ` [PATCH 10/12] ldbl-128ibm-compat: Redirect long double functions to f128/ieee128 functions Tulio Magno Quites Machado Filho
2018-06-20 20:54 ` Joseph Myers
2018-06-20 22:48 ` Tulio Magno Quites Machado Filho
2018-06-20 2:06 ` [PATCH 09/12] ldbl-128ibm-compat: Provide nexttoward functions Tulio Magno Quites Machado Filho
2018-06-20 20:46 ` Joseph Myers
2018-06-21 1:08 ` Tulio Magno Quites Machado Filho
2018-06-21 16:25 ` Joseph Myers
2018-06-20 2:06 ` [PATCH 08/12] ldbl-128ibm-compat: Provide a significand implementation Tulio Magno Quites Machado Filho
2018-06-20 20:40 ` Joseph Myers
2018-06-20 2:06 ` [PATCH 12/12] ldbl-128ibm-compat: Provide ieee128 symbols to narrow functions Tulio Magno Quites Machado Filho
2018-06-20 10:55 ` Joseph Myers [this message]
2018-06-21 16:53 ` [PATCHv2 00/12] Introduce ieee128 symbols and redirections Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1806201049210.3953@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=tuliom@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).