From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126078 invoked by alias); 20 Jun 2018 10:55:50 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 126063 invoked by uid 89); 20 Jun 2018 10:55:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Date: Wed, 20 Jun 2018 10:55:00 -0000 From: Joseph Myers To: Tulio Magno Quites Machado Filho CC: Subject: Re: [PATCH 12/12] ldbl-128ibm-compat: Provide ieee128 symbols to narrow functions In-Reply-To: <20180620020426.20372-13-tuliom@linux.ibm.com> Message-ID: References: <20180620020426.20372-1-tuliom@linux.ibm.com> <20180620020426.20372-13-tuliom@linux.ibm.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2018-06/txt/msg00603.txt.bz2 On Wed, 20 Jun 2018, Tulio Magno Quites Machado Filho wrote: > Add ieee128 aliases for faddl, fdivl, fmull, fsubl, daddl, ddivl, dmull, dsubl. > > 2018-06-19 Tulio Magno Quites Machado Filho > > * math/math-narrow.h [__HAVE_DISTINCT_FLOAT128 && > !__HAVE_FLOAT128_UNLIKE_LDBL] (libm_alias_float32_float128, I don't think __HAVE_FLOAT128_UNLIKE_LDBL is logically right here. That's about the current compilation, i.e. about whether these particular files end up getting built with IEEE long double. I don't know what files in the source tree might end up getting built with what long double setting, but it shouldn't matter for these files whether they are built with IEEE long double or not. Your property is something different, "glibc has *ieee128 aliases for _Float128 functions" (a property of the glibc configuration, not of the current compilation, but a different property from __HAVE_DISTINCT_FLOAT128). That suggests to me that either you need some new macro tested by this file, or you need e.g. math-narrow-alias-float128.h (included by math-narrow.h) which contains these float128 alias macros and for which ldbl-128ibm-compat provides a different version. -- Joseph S. Myers joseph@codesourcery.com