From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48968 invoked by alias); 20 Jun 2018 20:54:04 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 48953 invoked by uid 89); 20 Jun 2018 20:54:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Date: Wed, 20 Jun 2018 20:54:00 -0000 From: Joseph Myers To: Tulio Magno Quites Machado Filho CC: Subject: Re: [PATCH 10/12] ldbl-128ibm-compat: Redirect long double functions to f128/ieee128 functions In-Reply-To: <20180620020426.20372-11-tuliom@linux.ibm.com> Message-ID: References: <20180620020426.20372-1-tuliom@linux.ibm.com> <20180620020426.20372-11-tuliom@linux.ibm.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2018-06/txt/msg00633.txt.bz2 On Tue, 19 Jun 2018, Tulio Magno Quites Machado Filho wrote: > diff --git a/math/math.h b/math/math.h > index c1765e4c8c..8d0880b262 100644 > --- a/math/math.h > +++ b/math/math.h > @@ -283,6 +283,10 @@ enum > extern type __MATH_PRECNAME(function,suffix) args __THROW > #define __MATHDECL_1(type, function, suffix, args) \ > __MATHDECL_1_IMPL(type, function, suffix, args) > +/* Ignore the alias by default. The alias is only useful with > + redirections. */ > +#define __MATHDECL_ALIAS(type, function, suffix, args, alias) \ > + __MATHDECL_1_IMPL(type, function, suffix, args) So this is the default definitions of __MATHDECL_1 and __MATHDECL_ALIAS. > #define __MATHREDIR(type, function, suffix, args, to) \ > extern type __REDIRECT_NTH (__MATH_PRECNAME (function, suffix), args, to) > @@ -364,6 +368,39 @@ extern long double __REDIRECT_NTH (nexttowardl, > # undef __MATHDECL_1 > # define __MATHDECL_1(type, function,suffix, args) \ > __MATHREDIR(type, function, suffix, args, __CONCAT(function,suffix)) > + And this is the __LDBL_COMPAT redefinition, I think. You've moved various functions to use __MATHDECL_ALIAS, but __MATHDECL_ALIAS isn't being redefined for __LDBL_COMPAT. Are you sure that's correct? That is, what do the macro-generated declarations of functions using __MATHDECL_ALIAS look like in a -mlong-double-64 configuration, before and after this patch? > +#define __dremieee128 __remainderieee128 > +#define __gammaieee128 __lgammaieee128 These are missing appropriate preprocessor indendation for their nesting level inside #if. -- Joseph S. Myers joseph@codesourcery.com