From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74062 invoked by alias); 20 Jun 2018 21:00:24 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 73909 invoked by uid 89); 20 Jun 2018 21:00:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=principles X-HELO: relay1.mentorg.com Date: Wed, 20 Jun 2018 21:00:00 -0000 From: Joseph Myers To: Tulio Magno Quites Machado Filho CC: , Rajalakshmi Srinivasaraghavan Subject: Re: [PATCH 11/12] ldbl-128ibm-compat: Redirect complex math functions In-Reply-To: <20180620020426.20372-12-tuliom@linux.ibm.com> Message-ID: References: <20180620020426.20372-1-tuliom@linux.ibm.com> <20180620020426.20372-12-tuliom@linux.ibm.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2018-06/txt/msg00635.txt.bz2 I don't see any test infrastructure in this patch series for either the math.h or complex.h functions. Is that to be added separately? Principles include: * As ulps are currently identified as "ldouble" and "float128", those need to be appropriately associated with the correct formats in testing (which the testing already handles for getting _FloatN tests using the appropriate ulps, whatever type name those ulps may be listed with). * The libm functions built for each format should be tested. While most of the functions built for float128 are at least tested under their *f128 names, you have those such as __significandieee128 which don't have such a name and so need testing added for the code to get tested at all. * There should be at least some test coverage that the redirection works, i.e. tests built and run with binary128 long double. -- Joseph S. Myers joseph@codesourcery.com