From: Joseph Myers <joseph@codesourcery.com>
To: "Gabriel F. T. Gomes" <gabriel@inconstante.eti.br>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH 01/14] Prepare vfprintf to use __printf_fp/__printf_fphex with float128 arg
Date: Thu, 21 Jun 2018 21:22:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1806212119520.19363@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20180621021023.17036-2-gabriel@inconstante.eti.br>
On Wed, 20 Jun 2018, Gabriel F. T. Gomes wrote:
> +#if __HAVE_FLOAT128_UNLIKE_LDBL
> +# define PARSE_FLOAT_VA_ARG_EXTENDED(INFO) \
> + if (LDBL_USES_FLOAT128 && is_long_double) \
> + { \
> + INFO.is_binary128 = 1; \
> + the_arg.pa_float128 = va_arg (ap, _Float128); \
> + } \
> + else \
> + { \
> + PARSE_FLOAT_VA_ARG (INFO) \
> + }
I'd expect all these macros to be implemented in the do { ... } while (0)
style, so that they do genuinely act as single statements when followed by
';', and then to be followed by ';' at the sites where they are used (so
avoiding editors messing up indentation at / after those sites), unless
there is some reason that convention can't work here.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2018-06-21 21:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 2:10 [PATCH 00/14] Functions with format string for IEEE128 on powercpc64le Gabriel F. T. Gomes
2018-06-21 2:10 ` [PATCH 02/14] Prepare vfscanf to use __strtof128_internal Gabriel F. T. Gomes
2018-06-21 21:35 ` Joseph Myers
2018-06-21 21:39 ` Zack Weinberg
2018-12-07 20:16 ` Gabriel F. T. Gomes
2018-06-21 2:10 ` [PATCH 01/14] Prepare vfprintf to use __printf_fp/__printf_fphex with float128 arg Gabriel F. T. Gomes
2018-06-21 21:22 ` Joseph Myers [this message]
2018-12-07 20:16 ` Gabriel F. T. Gomes
2018-12-18 11:18 ` Ping Re: [PATCH v2] " Gabriel F. T. Gomes
2018-12-18 12:13 ` [PATCH 01/14] " Florian Weimer
2018-12-18 13:37 ` Gabriel F. T. Gomes
2018-12-19 15:57 ` Florian Weimer
2018-06-21 2:10 ` [PATCH 03/14] Add internal implementations for argp.h, err.h, and error.h functions Gabriel F. T. Gomes
2018-06-21 21:36 ` Joseph Myers
2018-06-21 2:11 ` [PATCH 08/14] ldbl-128ibm-compat: Test double values Gabriel F. T. Gomes
2018-06-21 2:11 ` [PATCH 05/14] ldbl-128ibm-compat: Add wide character printing functions Gabriel F. T. Gomes
2018-06-21 2:11 ` [PATCH 11/14] ldbl-128ibm-compat: Add argp_error and argp_failure Gabriel F. T. Gomes
2018-06-21 2:11 ` [PATCH 12/14] ldbl-128ibm-compat: Add err.h functions Gabriel F. T. Gomes
2018-06-21 2:11 ` [PATCH 04/14] ldbl-128ibm-compat: Add regular character printing functions Gabriel F. T. Gomes
2018-06-21 21:03 ` Joseph Myers
2018-06-21 2:11 ` [PATCH 06/14] ldbl-128ibm-compat: Add regular character, fortified " Gabriel F. T. Gomes
2018-06-21 2:11 ` [PATCH 10/14] ldbl-128ibm-compat: Add wide character scanning functions Gabriel F. T. Gomes
2018-06-21 2:11 ` [PATCH 14/14] ldbl-128ibm-compat: Add tests for err.h and error.h functions Gabriel F. T. Gomes
2018-06-21 2:11 ` [PATCH 07/14] ldbl-128ibm-compat: Add wide character, fortified printing functions Gabriel F. T. Gomes
2018-06-21 2:11 ` [PATCH 13/14] ldbl-128ibm-compat: Add error.h functions Gabriel F. T. Gomes
2018-06-21 2:11 ` [PATCH 09/14] ldbl-128ibm-compat: Add regular character scanning functions Gabriel F. T. Gomes
2018-06-21 16:44 ` [PATCH 00/14] Functions with format string for IEEE128 on powercpc64le Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1806212119520.19363@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gabriel@inconstante.eti.br \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).