From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-93754-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 64077 invoked by alias); 28 Jun 2018 17:24:46 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 50144 invoked by uid 89); 28 Jun 2018 17:24:37 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=H*f:sk:DB5PR08, H*i:sk:DB5PR08
X-HELO: relay1.mentorg.com
Date: Thu, 28 Jun 2018 17:24:00 -0000
From: Joseph Myers <joseph@codesourcery.com>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
CC: "libc-alpha@sourceware.org" <libc-alpha@sourceware.org>, nd <nd@arm.com>
Subject: Re: [PATCH1/2] Improve performance of sincosf
In-Reply-To: <DB5PR08MB10301908C58D8A9DD1C847BA83490@DB5PR08MB1030.eurprd08.prod.outlook.com>
Message-ID: <alpine.DEB.2.20.1806281722410.16299@digraph.polyomino.org.uk>
References: <DB5PR08MB10301908C58D8A9DD1C847BA83490@DB5PR08MB1030.eurprd08.prod.outlook.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
X-SW-Source: 2018-06/txt/msg00908.txt.bz2

On Tue, 26 Jun 2018, Wilco Dijkstra wrote:

> +/* New sincosf.  */

Comments describing something as new are never appropriate; they'll 
always become out of date.

> +extern sincos_t sincosf_table[2] attribute_hidden;

I'd expect this array, and thus all pointers to it, to be const; any 
writable static / global data is suspect without a clear requirement for 
it to be writable.

-- 
Joseph S. Myers
joseph@codesourcery.com